On Fri, Oct 4, 2013 at 6:30 AM, Kyle Mestery (kmestery)
wrote:
> On Oct 3, 2013, at 2:31 PM, Jesse Gross wrote:
>> On Thu, Oct 3, 2013 at 9:46 AM, Kyle Mestery (kmestery)
>> wrote:
>>> So, we realize the need to add the NSH code upstream into the kernel.
>>> But in parallel to this work, we're w
On Oct 3, 2013, at 2:31 PM, Jesse Gross wrote:
> On Thu, Oct 3, 2013 at 9:46 AM, Kyle Mestery (kmestery)
> wrote:
>> So, we realize the need to add the NSH code upstream into the kernel.
>> But in parallel to this work, we're wondering if it would be ok to add a new
>> vport-nsh in the data path
On Thu, Oct 3, 2013 at 9:46 AM, Kyle Mestery (kmestery)
wrote:
> So, we realize the need to add the NSH code upstream into the kernel.
> But in parallel to this work, we're wondering if it would be ok to add a new
> vport-nsh in the data path code. This would allow for stacking NSH headers
> on wh
On Tue, Oct 1, 2013 at 2:44 PM, Jarno Rajahalme wrote:
> On Sep 20, 2013, at 1:04 AM, pritesh wrote:
>> diff --git a/datapath/linux/compat/include/net/vxlan.h
>> b/datapath/linux/compat/include/net/vxlan.h
>> index 3ac816b..1c15dfb 100644
>> --- a/datapath/linux/compat/include/net/vxlan.h
>> +++
On Oct 1, 2013, at 4:44 PM, Jarno Rajahalme wrote:
>
> On Sep 20, 2013, at 1:04 AM, pritesh wrote:
>
>> This patch adds support for Network Service Headers (nsh) over VXLAN
>> as mentioned in [1]. Here changes are made to datapath to add nsh
>> headers whenever a vxlan port with destination po
>> vxlan.c:118: if (vxh->vx_flags != htonl(VXLAN_FLAGS) || (vxh->vx_vni &
>> htonl(0xff))) {
>>
>> or if (unlikely(nsh->b.svc_path & htonl(NSH_M_NSI))) { // NSH_M_NSI ==>
>> 0x00ff which is same as 0xff above?
>> am i missing something here?
>>
>
> I did not check if the NSH spec tells to
> On Oct 1, 2013, at 6:36 PM, "Pritesh Kothari (pritkoth)"
> wrote:
>
>> Also, the usual treatment of reserved bits is ignore on reception, rather
>> than
>> dropping.
>
> hmm. i didn't quite get what you are saying here, vxlan_vni and svc_path both
> use upper 24bits
> and their detection s
btw, first and foremost, thanks for the review, i greatly appreciate it :)
>> diff --git a/datapath/flow.c b/datapath/flow.c
>> index 29122af..4f47a48 100644
>> --- a/datapath/flow.c
>> +++ b/datapath/flow.c
>> @@ -1235,6 +1235,7 @@ int ovs_ipv4_tun_from_nlattr(const struct nlattr *attr,
>> i
On Sep 20, 2013, at 1:04 AM, pritesh wrote:
> This patch adds support for Network Service Headers (nsh) over VXLAN
> as mentioned in [1]. Here changes are made to datapath to add nsh
> headers whenever a vxlan port with destination port as 9030 is created.
> IANA port allocation for nsh over vxl
On Oct 1, 2013, at 11:03 AM, Jarno Rajahalme wrote:
>
> On Oct 1, 2013, at 10:07 AM, Pritesh Kothari (pritkoth)
> wrote:
>
>>
>> On Sep 30, 2013, at 5:46 PM, Jesse Gross wrote:
>>
>>> On Fri, Sep 20, 2013 at 1:04 AM, pritesh wrote:
This patch adds support for Network Service Headers (
On Oct 1, 2013, at 12:08 PM, Jesse Gross wrote:
> On Tue, Oct 1, 2013 at 10:07 AM, Pritesh Kothari (pritkoth)
> wrote:
>> On Sep 30, 2013, at 5:46 PM, Jesse Gross wrote:
>>> One other thing - would you mind using your full name in the signed-off-by
>>> line?
>>
>> i generally prefer just my fi
On Tue, Oct 1, 2013 at 10:07 AM, Pritesh Kothari (pritkoth)
wrote:
> On Sep 30, 2013, at 5:46 PM, Jesse Gross wrote:
>> One other thing - would you mind using your full name in the signed-off-by
>> line?
>
> i generally prefer just my first name, but if its needed i can use my full
> name here.
On Oct 1, 2013, at 10:07 AM, Pritesh Kothari (pritkoth)
wrote:
>
> On Sep 30, 2013, at 5:46 PM, Jesse Gross wrote:
>
>> On Fri, Sep 20, 2013 at 1:04 AM, pritesh wrote:
>>> This patch adds support for Network Service Headers (nsh) over VXLAN
>>> as mentioned in [1]. Here changes are made to d
On Sep 30, 2013, at 5:46 PM, Jesse Gross wrote:
> On Fri, Sep 20, 2013 at 1:04 AM, pritesh wrote:
>> This patch adds support for Network Service Headers (nsh) over VXLAN
>> as mentioned in [1]. Here changes are made to datapath to add nsh
>> headers whenever a vxlan port with destination port as
On Fri, Sep 20, 2013 at 1:04 AM, pritesh wrote:
> This patch adds support for Network Service Headers (nsh) over VXLAN
> as mentioned in [1]. Here changes are made to datapath to add nsh
> headers whenever a vxlan port with destination port as 9030 is created.
> IANA port allocation for nsh over v
This patch adds support for Network Service Headers (nsh) over VXLAN
as mentioned in [1]. Here changes are made to datapath to add nsh
headers whenever a vxlan port with destination port as 9030 is created.
IANA port allocation for nsh over vxlan is yet to be done.
[1] http://tools.ietf.org/html/d
16 matches
Mail list logo
