On Tue, Oct 1, 2013 at 2:44 PM, Jarno Rajahalme <jrajaha...@nicira.com> wrote:
> On Sep 20, 2013, at 1:04 AM, pritesh <pritesh.koth...@cisco.com> wrote:
>> diff --git a/datapath/linux/compat/include/net/vxlan.h
>> b/datapath/linux/compat/include/net/vxlan.h
>> index 3ac816b..1c15dfb 100644
>> --- a/datapath/linux/compat/include/net/vxlan.h
>> +++ b/datapath/linux/compat/include/net/vxlan.h
>> @@ -4,9 +4,11 @@
>> #include <linux/skbuff.h>
>> #include <linux/netdevice.h>
>> #include <linux/udp.h>
>> +#include <net/nsh.h>
>>
>> struct vxlan_sock;
>> -typedef void (vxlan_rcv_t)(struct vxlan_sock *vs, struct sk_buff *skb,
>> __be32 key);
>> +typedef void (vxlan_rcv_t)(struct vxlan_sock *vs, struct sk_buff *skb,
>> + __be32 key, __be32 nsp);
>>
>> /* per UDP socket information */
>> struct vxlan_sock {
>> @@ -27,7 +29,7 @@ void vxlan_sock_release(struct vxlan_sock *vs);
>> int vxlan_xmit_skb(struct vxlan_sock *vs,
>> struct rtable *rt, struct sk_buff *skb,
>> __be32 src, __be32 dst, __u8 tos, __u8 ttl, __be16 df,
>> - __be16 src_port, __be16 dst_port, __be32 vni);
>> + __be16 src_port, __be16 dst_port, __be32 vni, __be32 nsp);
>
> I'm not exactly sure on the policy about the compat files, but I think they
> should be about compatibility with older kernels. Hence I'm not sure if
> this is the right place to introduce new functionality. Could someone
> comment on this?
That's generally true although we do put functionality in there that
we expect to be merged upstream shortly in the same form (effectively
assuming that the current kernel will soon become an "older" kernel).
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
