Re: [ovs-dev] [PATCH 1/4] ofproto-dpif: Systematically push stats upon request.

2013-04-01 Thread Ben Pfaff
On Mon, Apr 01, 2013 at 03:29:14PM -0700, Ethan Jackson wrote: > Here's an incremental which I think should address your concerns. Yes, that's fine, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/4] ofproto-dpif: Systematically push stats upon request.

2013-04-01 Thread Ethan Jackson
Here's an incremental which I think should address your concerns. --- ofproto/ofproto-dpif.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 69d59fc..0b16bfa 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -50

Re: [ovs-dev] [PATCH 1/4] ofproto-dpif: Systematically push stats upon request.

2013-04-01 Thread Ben Pfaff
On Sun, Mar 31, 2013 at 06:22:56PM -0700, Ethan Jackson wrote: > Commit bf1e8ff (ofproto-dpif: Push statistics in rule_get_stats()), > started down the road towards pushing stats on demand, but it > didn't go quite far enough. First, it neglected to push stats in > port_get_stats() and mirror_get_

[ovs-dev] [PATCH 1/4] ofproto-dpif: Systematically push stats upon request.

2013-03-31 Thread Ethan Jackson
Commit bf1e8ff (ofproto-dpif: Push statistics in rule_get_stats()), started down the road towards pushing stats on demand, but it didn't go quite far enough. First, it neglected to push stats in port_get_stats() and mirror_get_stats(). Second, it only pushes stats for a single ofproto, making it