On Sun, Mar 31, 2013 at 06:22:56PM -0700, Ethan Jackson wrote: > Commit bf1e8ff (ofproto-dpif: Push statistics in rule_get_stats()), > started down the road towards pushing stats on demand, but it > didn't go quite far enough. First, it neglected to push stats in > port_get_stats() and mirror_get_stats(). Second, it only pushes > stats for a single ofproto, making it incomplete when patch ports > are used. > > Signed-off-by: Ethan Jackson <et...@nicira.com>
I think that this will make handling some OpenFlow requests needlessly expensive. For example, "ovs-ofctl dump-ports" calls port_get_stats() on every port and "ovs-ofctl dump-stats" calls rule_get_stats() on every flow. If we can work that out, then this looks like a nice improvement. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
