Re: [ovs-dev] [PATCH 1/4] lib/classifier: Unify struct classifier and cls_classifier.

2014-07-18 Thread Jarno Rajahalme
Thanks for the reviews, pushed to master. Jarno On Jul 17, 2014, at 10:40 AM, Ben Pfaff wrote: > On Thu, Jul 17, 2014 at 07:09:15AM -0700, Jarno Rajahalme wrote: >> >> On Jul 15, 2014, at 10:18 PM, YAMAMOTO Takashi >> wrote: >> /* A flow classifier. */ struct classifier { -

Re: [ovs-dev] [PATCH 1/4] lib/classifier: Unify struct classifier and cls_classifier.

2014-07-17 Thread Ben Pfaff
On Thu, Jul 17, 2014 at 07:09:15AM -0700, Jarno Rajahalme wrote: > > On Jul 15, 2014, at 10:18 PM, YAMAMOTO Takashi wrote: > > >> /* A flow classifier. */ > >> struct classifier { > >> -struct cls_classifier *cls; > >> +struct ovs_mutex mutex; > >> +int n_rules OVS_GUARDED;/*

Re: [ovs-dev] [PATCH 1/4] lib/classifier: Unify struct classifier and cls_classifier.

2014-07-17 Thread Jarno Rajahalme
On Jul 15, 2014, at 10:18 PM, YAMAMOTO Takashi wrote: >> /* A flow classifier. */ >> struct classifier { >> -struct cls_classifier *cls; >> +struct ovs_mutex mutex; >> +int n_rules OVS_GUARDED;/* Total number of rules. */ >> +uint8_t n_flow_segments; >> +uint8_t flow_

Re: [ovs-dev] [PATCH 1/4] lib/classifier: Unify struct classifier and cls_classifier.

2014-07-16 Thread Ben Pfaff
On Wed, Jul 16, 2014 at 02:18:30PM +0900, YAMAMOTO Takashi wrote: > > /* A flow classifier. */ > > struct classifier { > > -struct cls_classifier *cls; > > +struct ovs_mutex mutex; > > +int n_rules OVS_GUARDED;/* Total number of rules. */ > > +uint8_t n_flow_segments; > >

Re: [ovs-dev] [PATCH 1/4] lib/classifier: Unify struct classifier and cls_classifier.

2014-07-15 Thread YAMAMOTO Takashi
> /* A flow classifier. */ > struct classifier { > -struct cls_classifier *cls; > +struct ovs_mutex mutex; > +int n_rules OVS_GUARDED;/* Total number of rules. */ > +uint8_t n_flow_segments; > +uint8_t flow_segments[CLS_MAX_INDICES]; /* Flow segment boundaries to use >

Re: [ovs-dev] [PATCH 1/4] lib/classifier: Unify struct classifier and cls_classifier.

2014-07-15 Thread Ben Pfaff
On Fri, Jul 11, 2014 at 04:55:54AM -0700, Jarno Rajahalme wrote: > Now that it is clear that struct cls_classifier itself does not > need RCU indirection and pvector is defined in its own header, it > is possible get rid of the indirection from struct classifier to > struct cls_classifier. > > Sug

[ovs-dev] [PATCH 1/4] lib/classifier: Unify struct classifier and cls_classifier.

2014-07-11 Thread Jarno Rajahalme
Now that it is clear that struct cls_classifier itself does not need RCU indirection and pvector is defined in its own header, it is possible get rid of the indirection from struct classifier to struct cls_classifier. Suggested-by: YAMAMOTO Takashi Signed-off-by: Jarno Rajahalme --- lib/classif