On Wed, Jul 16, 2014 at 02:18:30PM +0900, YAMAMOTO Takashi wrote:
> > /* A flow classifier. */
> > struct classifier {
> > - struct cls_classifier *cls;
> > + struct ovs_mutex mutex;
> > + int n_rules OVS_GUARDED; /* Total number of rules. */
> > + uint8_t n_flow_segments;
> > + uint8_t flow_segments[CLS_MAX_INDICES]; /* Flow segment boundaries to
> > use
> > + * for staged lookup. */
> > + struct cmap subtables_map; /* Contains "struct cls_subtable"s. */
> > + struct pvector subtables;
> > + struct cmap partitions; /* Contains "struct cls_partition"s. */
> > + struct cls_trie tries[CLS_MAX_TRIES]; /* Prefix tries. */
> > + unsigned int n_tries;
> > };
>
> i think a forward decl of the structure is enough for classifier.h.
> i always prefer hiding details from consumers where reasonable.
I agree.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
