Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath interface

2014-08-14 Thread Saurabh Shah
Hi Nithin, > -Original Message- > From: Nithin Raju > Sent: Thursday, August 14, 2014 5:56 PM > To: Saurabh Shah > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath > interface > > On Aug 14, 2014, at 5:01

Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath interface

2014-08-14 Thread Nithin Raju
On Aug 14, 2014, at 5:56 PM, Nithin Raju wrote: >> Since we define & control the dp interface, why not just include >> OvsDpInterfaceExt.h directly? (Just like what we used to do earlier by >> including OvsPub.h.) > > If we include OvsDpInterfaceExt.h, we'll have to have a #ifdef _WIN32. IMO,

Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath interface

2014-08-14 Thread Nithin Raju
On Aug 14, 2014, at 5:01 PM, Saurabh Shah wrote: >> +#define OVS_DEVICE_NAME_USER TEXT(".\\OpenVSwitchDevice") >> + > > Should be "OpenvSwitchDevice". Sure. I'll change this. >> +#ifdef _WIN32 >> +#include "OvsDpInterfaceExt.h" >> +#endif > > Since we define & control the dp interface,

Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath interface

2014-08-14 Thread Saurabh Shah
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju > Sent: Wednesday, August 13, 2014 7:12 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath > interface > > The datap

Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath interface

2014-08-14 Thread Ankur Sharma
Hi Nithin, Changes look fine to me. We should wait to see if alin/sam has some inputs on this. Regards, Ankur From: dev on behalf of Nithin Raju Sent: Wednesday, August 13, 2014 7:11 PM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH 1/4] Add

[ovs-dev] [PATCH 1/4] Add extentions to the standard datapath interface

2014-08-13 Thread Nithin Raju
The datapath interface defined in odp-netlink.h needs some extensions that are platform dependent. Some examples are the name of the communication device on Windows and a set of commands that are specific to Windows. In this change we define a include/odp-netlink-ext.h to in turn include any platf