Re: [ovs-dev] [PATCH 1/3] ofproto-macros: Fix definition of add_of_ports.

2016-02-05 Thread Jarno Rajahalme
> On Feb 5, 2016, at 4:06 PM, Ben Pfaff wrote: > > On Fri, Feb 05, 2016 at 03:49:24PM -0800, Jarno Rajahalme wrote: >> Sorry for not spotting this on review, I must have assumed that if the >> tests pass it must be correct! > > It's funny, I remember fixing this particular bug at some point bef

Re: [ovs-dev] [PATCH 1/3] ofproto-macros: Fix definition of add_of_ports.

2016-02-05 Thread Ben Pfaff
On Fri, Feb 05, 2016 at 03:49:24PM -0800, Jarno Rajahalme wrote: > Sorry for not spotting this on review, I must have assumed that if the > tests pass it must be correct! It's funny, I remember fixing this particular bug at some point before I applied the earlier patch, but I guess it got lost. >

Re: [ovs-dev] [PATCH 1/3] ofproto-macros: Fix definition of add_of_ports.

2016-02-05 Thread Jarno Rajahalme
Sorry for not spotting this on review, I must have assumed that if the tests pass it must be correct! A reference to the commit this fixes would be nice. Acked-by: Jarno Rajahalme > On Feb 5, 2016, at 3:30 PM, Ben Pfaff wrote: > > This definition just didn't work, and caused lots of tests to

[ovs-dev] [PATCH 1/3] ofproto-macros: Fix definition of add_of_ports.

2016-02-05 Thread Ben Pfaff
This definition just didn't work, and caused lots of tests to inadvertently be effectively skipped. Signed-off-by: Ben Pfaff --- tests/ofproto-macros.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 354a384..c6c332