Re: [ovs-dev] [PATCH 1/3] ofproto: Add coverage for port additions and deletions.

2012-06-22 Thread Ethan Jackson
I had missed those counters. I think they more accurately reflect what we want, so I'll drop this patch. Ethan On Fri, Jun 22, 2012 at 9:07 AM, Ben Pfaff wrote: > On Thu, Jun 21, 2012 at 06:51:32PM -0700, Ethan Jackson wrote: >> Since port additions and deletions can be very expensive, it makes

Re: [ovs-dev] [PATCH 1/3] ofproto: Add coverage for port additions and deletions.

2012-06-22 Thread Ben Pfaff
On Thu, Jun 21, 2012 at 06:51:32PM -0700, Ethan Jackson wrote: > Since port additions and deletions can be very expensive, it makes > sense to keep coverage for them. > > Signed-off-by: Ethan Jackson I think these duplicate the dpif_port_add and dpif_port_del counters. (If you think that ofproto

[ovs-dev] [PATCH 1/3] ofproto: Add coverage for port additions and deletions.

2012-06-21 Thread Ethan Jackson
Since port additions and deletions can be very expensive, it makes sense to keep coverage for them. Signed-off-by: Ethan Jackson --- ofproto/ofproto.c |4 1 file changed, 4 insertions(+) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 38430ab..18f9b3c 100644 --- a/ofproto/ofpr