Re: [ovs-dev] [PATCH 1/2] tests: Clean up idltest on distclean.

2014-05-28 Thread Ben Pfaff
Well, maybe separate distcleancheck should work too. I don't know. The automake manual only talks about it in the context of distcheck, though. On Thu, May 29, 2014 at 09:26:15AM +1200, Joe Stringer wrote: > Ahuh! Yes, I was running distcleancheck separately. I suppose that would > explain it. I'

Re: [ovs-dev] [PATCH 1/2] tests: Clean up idltest on distclean.

2014-05-28 Thread Joe Stringer
Ahuh! Yes, I was running distcleancheck separately. I suppose that would explain it. I'll take a look at your patch. On 29 May 2014 05:37, Ben Pfaff wrote: > I tried running "make distcheck", which includes a call to > distcleancheck, and only found one problem. I sent out a patch: > h

Re: [ovs-dev] [PATCH 1/2] tests: Clean up idltest on distclean.

2014-05-28 Thread Ben Pfaff
I tried running "make distcheck", which includes a call to distcleancheck, and only found one problem. I sent out a patch: http://openvswitch.org/pipermail/dev/2014-May/040737.html I don't know why you would get different results. Are you running distcleancheck separately from distcheck?

Re: [ovs-dev] [PATCH 1/2] tests: Clean up idltest on distclean.

2014-05-27 Thread Joe Stringer
Right, I didn't see that before. So I'm a bit confused why the distcleancheck target is complaining about these files. Are the ovsidl test files added to OVSIDL_BUILT after it is added to EXTRA_DIST? I see it complaining about lib/socket-util-unix.{lo,o} now, too. On 28 May 2014 03:11, Ben Pfaf

Re: [ovs-dev] [PATCH 1/2] tests: Clean up idltest on distclean.

2014-05-27 Thread Ben Pfaff
On Tue, May 27, 2014 at 01:46:59PM +1200, Joe Stringer wrote: > This was causing failures in 'make distcleancheck'. > > Signed-off-by: Joe Stringer OVSIDL_BUILT is already in EXTRA_DIST. It doesn't make sense to have files be both distributed and distcleaned. ___

[ovs-dev] [PATCH 1/2] tests: Clean up idltest on distclean.

2014-05-26 Thread Joe Stringer
This was causing failures in 'make distcleancheck'. Signed-off-by: Joe Stringer --- tests/automake.mk |1 + 1 file changed, 1 insertion(+) diff --git a/tests/automake.mk b/tests/automake.mk index 9354fad..bf943ce 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -199,6 +199,7 @@ tes