Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-16 Thread Jesse Gross
On Thu, Jul 16, 2015 at 12:23 AM, Ben Pfaff wrote: > On Wed, Jul 15, 2015 at 03:53:27PM -0700, Jesse Gross wrote: >> On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: >> > On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: >> >> There are several implementations of functions that parse

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-16 Thread Jesse Gross
On Wed, Jul 15, 2015 at 10:52 PM, Joe Stringer wrote: > On 15 July 2015 at 17:41, Jesse Gross wrote: >> On Wed, Jul 15, 2015 at 5:31 PM, Joe Stringer wrote: >>> On 15 July 2015 at 15:53, Jesse Gross wrote: On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 02

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 03:53:27PM -0700, Jesse Gross wrote: > On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: > > On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: > >> There are several implementations of functions that parse/format > >> flags and their binary representation. This

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Joe Stringer
On 15 July 2015 at 17:41, Jesse Gross wrote: > On Wed, Jul 15, 2015 at 5:31 PM, Joe Stringer wrote: >> On 15 July 2015 at 15:53, Jesse Gross wrote: >>> On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: > There are several im

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Jesse Gross
On Wed, Jul 15, 2015 at 5:41 PM, Jesse Gross wrote: > On Wed, Jul 15, 2015 at 5:31 PM, Joe Stringer wrote: >> On 15 July 2015 at 15:53, Jesse Gross wrote: >>> On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: > There are sev

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Jesse Gross
On Wed, Jul 15, 2015 at 5:31 PM, Joe Stringer wrote: > On 15 July 2015 at 15:53, Jesse Gross wrote: >> On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: >>> On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: There are several implementations of functions that parse/format fl

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Joe Stringer
On 15 July 2015 at 15:53, Jesse Gross wrote: > On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: >> On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: >>> There are several implementations of functions that parse/format >>> flags and their binary representation. This factors them out i

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Jesse Gross
On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: >> There are several implementations of functions that parse/format >> flags and their binary representation. This factors them out into >> common routines. In addition to reducing cod

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: > There are several implementations of functions that parse/format > flags and their binary representation. This factors them out into > common routines. In addition to reducing code, it also makes things > more consistent across differen

[ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-13 Thread Jesse Gross
There are several implementations of functions that parse/format flags and their binary representation. This factors them out into common routines. In addition to reducing code, it also makes things more consistent across different parts of OVS. Signed-off-by: Jesse Gross --- lib/flow.c