Re: [ovs-dev] [PATCH 1/2] V4 linux datapath Adds 802.1ad (qinq) support

2014-10-23 Thread Thomas F Herbert
On 10/16/14, 11:54 AM, Ben Pfaff wrote: On Thu, Oct 16, 2014 at 08:56:32AM -0400, Thomas F Herbert wrote: Why is OVS_KEY_ATTR_CVLAN needed? The expectation when we designed the Netlink flow structures was that nested VLANs would be implemented as multiple nested attributes. Ben, OK. I will red

Re: [ovs-dev] [PATCH 1/2] V4 linux datapath Adds 802.1ad (qinq) support

2014-10-16 Thread Ben Pfaff
On Thu, Oct 16, 2014 at 08:56:32AM -0400, Thomas F Herbert wrote: > >Why is OVS_KEY_ATTR_CVLAN needed? The expectation when we designed > >the Netlink flow structures was that nested VLANs would be implemented > >as multiple nested attributes. > Ben, OK. I will redo to use nested attributes. Why

Re: [ovs-dev] [PATCH 1/2] V4 linux datapath Adds 802.1ad (qinq) support

2014-10-16 Thread Thomas F Herbert
Ben, Thanks for your effort to review this patch. I will fix and resubmit. On 10/15/14, 6:30 PM, Ben Pfaff wrote: On Sat, Oct 11, 2014 at 08:56:06PM -0400, Thomas F Herbert wrote: This is the linux kernel portion of the patch. Signed-off-by: Thomas F Herbert The ovs_key_attr values

Re: [ovs-dev] [PATCH 1/2] V4 linux datapath Adds 802.1ad (qinq) support

2014-10-15 Thread Ben Pfaff
On Sat, Oct 11, 2014 at 08:56:06PM -0400, Thomas F Herbert wrote: > This is the linux kernel portion of the patch. > > Signed-off-by: Thomas F Herbert In the subject, it's customary to put the version number inside the brackets so that it doesn't get into the commit message. Compiling against L

[ovs-dev] [PATCH 1/2] V4 linux datapath Adds 802.1ad (qinq) support

2014-10-11 Thread Thomas F Herbert
This is the linux kernel portion of the patch. Signed-off-by: Thomas F Herbert --- datapath/actions.c| 27 ++-- datapath/flow.c | 80 +++ datapath/flow.h | 1 + datapath/f