Ben,
Thanks for your effort to review this patch. I will fix and resubmit.
On 10/15/14, 6:30 PM, Ben Pfaff wrote:
On Sat, Oct 11, 2014 at 08:56:06PM -0400, Thomas F Herbert wrote:
This is the linux kernel portion of the patch.
Signed-off-by: Thomas F Herbert <thomasfherb...@entpnt.com>
....
The ovs_key_attr values are part of the ABI so you shouldn't add a new
value in the middle.
Why is OVS_KEY_ATTR_CVLAN needed? The expectation when we designed
the Netlink flow structures was that nested VLANs would be implemented
as multiple nested attributes.
Ben, OK. I will redo to use nested attributes. Why does mpls have key
attributes?
I didn't read all of the kernel code so this isn't a full review.
Thanks,
Ben.
--
Thomas F. Herbert
Network Implementation Engineer
Entry Point LLC
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
