Le 25/08/2011 01:07, Ben Pfaff a écrit :
>
> Hi Philippe. Just dropping you a note to let you know that I haven't
> forgotten your patch. I spent some time writing a separate commit
> that fixes the bug that you reported and posted it in this thread,
> along with some unit tests for VLANs:
>
On Tue, Aug 23, 2011 at 12:54:19AM +0200, Philippe Jung wrote:
> Le 22/08/2011 22:27, Ben Pfaff a ?crit :
>
> > I think you're right. I guess nobody (except you) tests trunking a
> > limited set of VLANs. We should fix this, thanks for the bug report.
>
> Please find enclosed the new version of
Le 23/08/2011 01:16, Ben Pfaff a écrit :
> On Tue, Aug 23, 2011 at 12:54:19AM +0200, Philippe Jung wrote:
>> If needed, I can post my OpenOffice table where I have written all
>> tests I have performed
>
> That would actually be great. I'd like to convert them to unit tests.
Regarding the tests:
On Tue, Aug 23, 2011 at 12:54:19AM +0200, Philippe Jung wrote:
> If needed, I can post my OpenOffice table where I have written all
> tests I have performed
That would actually be great. I'd like to convert them to unit tests.
___
dev mailing list
dev@o
Le 22/08/2011 22:27, Ben Pfaff a écrit :
> I think you're right. I guess nobody (except you) tests trunking a
> limited set of VLANs. We should fix this, thanks for the bug report.
Please find enclosed the new version of the patch to add native VLAN feature.
Compared to previous version, major
On Mon, Aug 22, 2011 at 10:17:03PM +0200, Philippe Jung wrote:
> In original ofproto-dpif.c, line 1058, I read
>
> 1058 /* Get trunked VLANs. */
> 1059 trunks = s->vlan == -1 ? NULL : s->trunks;
>
> Is there a reason to explain that when the port is trunk (vlan=-1),
> trunks is set to nul
Le 18/08/2011 10:19, Jesse Gross a écrit :
> On Aug 18, 2011 2
> I would make the change everywhere. The above list looks good, although
> I think it might be better to reverse the native names (i.e.
> "native-tagged" instead of "tagged-native") as it groups things together
> a little better.
>
On Aug 18, 2011 4:30 AM, "Philippe Jung" wrote:
>
> Le 17/08/2011 03:37, Jesse Gross a écrit :
>
> >
> > This is the same as native vlan, right? If so, I think that is a
> > better name as it is more common and PVID sounds like it should refer
> > to private vlans.
>
> Yes, also called default VL
Le 17/08/2011 03:37, Jesse Gross a écrit :
>
> This is the same as native vlan, right? If so, I think that is a
> better name as it is more common and PVID sounds like it should refer
> to private vlans.
Yes, also called default VLAN. Do I make the change just in comments or
also in the new col
On Wed, Aug 17, 2011 at 12:33:55AM +0200, Philippe Jung wrote:
> Also fixed a typo in INSTALL.Linux still referencing --with-l26
I committed this part and added you to AUTHORS too (so you can skip
that part of the feedback on your patch).
Thanks,
Ben.
On Wed, Aug 17, 2011 at 12:33:55AM +0200, Philippe Jung wrote:
> Please find a new version of the patch against master branch, non word
> wrapped, with updated doc. Also fixed a typo in INSTALL.Linux still
> referencing --with-l26
Thanks. This version applies well. I have some comments to add
On Wed, Aug 17, 2011 at 6:33 AM, Philippe Jung wrote:
> Le 03/08/2011 18:30, Ben Pfaff a écrit :
>> On Sat, Jul 30, 2011 at 01:41:04AM +0200, Philippe Jung wrote:
>>> This patchs adds the PVID (Port VLAN ID) tagging feature to the
>>> switch ports:
>>> - When an untagged packet is received by a sw
Le 03/08/2011 18:30, Ben Pfaff a écrit :
> On Sat, Jul 30, 2011 at 01:41:04AM +0200, Philippe Jung wrote:
>> This patchs adds the PVID (Port VLAN ID) tagging feature to the
>> switch ports:
>> - When an untagged packet is received by a switch port from an
>> external device, the packet is tagged
Le 03/08/2011 18:30, Ben Pfaff a écrit :
Your implementation is against Open vSwitch 1.1.1. To commit it, you
will have to rewrite it against the Git "master" branch. A lot of
code has moved around in the meantime, so this will require a little
bit of work.
Will do this way.
The patch was sen
On Sat, Jul 30, 2011 at 01:41:04AM +0200, Philippe Jung wrote:
> This patchs adds the PVID (Port VLAN ID) tagging feature to the
> switch ports:
> - When an untagged packet is received by a switch port from an
> external device,
> the packet is tagged with PVID;
> - Tagged packets received by a s
Hi,
This patchs adds the PVID (Port VLAN ID) tagging feature to the switch
ports:
- When an untagged packet is received by a switch port from an external
device,
the packet is tagged with PVID;
- Tagged packets received by a switch port from an external device are
unchanged;
- When a tagge
16 matches
Mail list logo
