Le 03/08/2011 18:30, Ben Pfaff a écrit :
Your implementation is against Open vSwitch 1.1.1. To commit it, you
will have to rewrite it against the Git "master" branch. A lot of
code has moved around in the meantime, so this will require a little
bit of work.
Will do this way.
The patch was sent word-wrapped, so it can't be applied directly.
Ok, it looks like the use of git will also bring easier patch
generation. I will
pay attention to word-wrapping
the patch doesn't update the user
documentation for how to configure the vswitch, in
vswitchd/vswitch.xml. Please add that in the next version of the
patch.
OK
In vswitch/vswitch.ovsschema, it would be better to specify the pvid
column as optional and limit its value to the range 0...4095. That's
the same as the "tag" column, so you can reuse the JSON from there.
Will not be taken into account because of next paragraph. pvid column
is going
to be dropped.
I'd actually be inclined to, instead of adding two new columns, add a
single new "vlan_mode" column with an enumerated choice of values:
Does that make sense?
Makes sense. I am going to reimplement the patch this way.
Philippe
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
