Re: [ovs-dev] [PATCH 07/16] socket-util: Disable dscp setting on Windows.

2014-06-12 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 11:40:06AM -0700, Gurucharan Shetty wrote: > On Mon, Jun 9, 2014 at 3:17 PM, Ben Pfaff wrote: > > On Fri, May 30, 2014 at 12:06:15PM -0700, Gurucharan Shetty wrote: > >> According to msdn documentation, one is discouraged from using > >> IP_TOS for ipv4 sockets (it apparent

Re: [ovs-dev] [PATCH 07/16] socket-util: Disable dscp setting on Windows.

2014-06-10 Thread Gurucharan Shetty
On Mon, Jun 9, 2014 at 3:17 PM, Ben Pfaff wrote: > On Fri, May 30, 2014 at 12:06:15PM -0700, Gurucharan Shetty wrote: >> According to msdn documentation, one is discouraged from using >> IP_TOS for ipv4 sockets (it apparently does not actually set >> anything). Also, IPV6_TCLASS does not exist in

Re: [ovs-dev] [PATCH 07/16] socket-util: Disable dscp setting on Windows.

2014-06-09 Thread Ben Pfaff
On Fri, May 30, 2014 at 12:06:15PM -0700, Gurucharan Shetty wrote: > According to msdn documentation, one is discouraged from using > IP_TOS for ipv4 sockets (it apparently does not actually set > anything). Also, IPV6_TCLASS does not exist in > Windows. Looks like Microsoft recommends QoS2 APIs to

[ovs-dev] [PATCH 07/16] socket-util: Disable dscp setting on Windows.

2014-05-30 Thread Gurucharan Shetty
According to msdn documentation, one is discouraged from using IP_TOS for ipv4 sockets (it apparently does not actually set anything). Also, IPV6_TCLASS does not exist in Windows. Looks like Microsoft recommends QoS2 APIs to achieve the same. Till we add those API calls, simply return on Windows.