On Tue, Jun 10, 2014 at 11:40:06AM -0700, Gurucharan Shetty wrote: > On Mon, Jun 9, 2014 at 3:17 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Fri, May 30, 2014 at 12:06:15PM -0700, Gurucharan Shetty wrote: > >> According to msdn documentation, one is discouraged from using > >> IP_TOS for ipv4 sockets (it apparently does not actually set > >> anything). Also, IPV6_TCLASS does not exist in > >> Windows. Looks like Microsoft recommends QoS2 APIs to achieve > >> the same. Till we add those API calls, simply return on Windows. > >> > >> (Noticed while running unit tests for ipv6. set_dscp would fail.) > >> > >> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com> > > > > Why does this compile, if IPV6_TCLASS does not exist on Windows? > IPV6_TCLASS is defined inside a header file. But it is not documented > anywhere and does not work. Google says others have experienced the > same too. Looks like Cygwin disables it. > > So I will update the commit message to: > socket-util: Disable dscp setting on Windows. > > According to msdn documentation, one is discouraged from using > IP_TOS for ipv4 sockets (it apparently does not actually set > anything). Also, IPV6_TCLASS does not work in > Windows (it always returns an error and also is undocumented). > Looks like Microsoft recommends QoS2 APIs to achieve > the same. Till we add those API calls, simply return on Windows. > > (Noticed while running unit tests for ipv6. set_dscp would fail.) > > Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
Thanks for explaining. We have similar code in python/ovs/socket_util.py, I guess we should update it too? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
