Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-04 Thread Thomas Graf
On 02/03/15 at 05:55pm, Jesse Gross wrote: > On Tue, Feb 3, 2015 at 3:18 PM, Jesse Gross wrote: > > It seems like in general userspace should not allow different > > extensions to share the same datapath port. This perhaps isn't much of > > an issue right now but if you enable an extension on one

Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-03 Thread Jesse Gross
On Tue, Feb 3, 2015 at 3:18 PM, Jesse Gross wrote: > On Tue, Feb 3, 2015 at 2:33 PM, Thomas Graf wrote: >> On 02/03/15 at 02:25pm, Pravin Shelar wrote: >>> I agree port will continue to accept non GBP frames but sets >>> TUNNEL_VXLAN_OPT which is odd. Since it is checking extension for the >>> vp

Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-03 Thread Jesse Gross
On Tue, Feb 3, 2015 at 2:33 PM, Thomas Graf wrote: > On 02/03/15 at 02:25pm, Pravin Shelar wrote: >> I agree port will continue to accept non GBP frames but sets >> TUNNEL_VXLAN_OPT which is odd. Since it is checking extension for the >> vport. >> Why not set TUNNEL_VXLAN_OPT according to received

Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-03 Thread Thomas Graf
On 02/03/15 at 02:25pm, Pravin Shelar wrote: > I agree port will continue to accept non GBP frames but sets > TUNNEL_VXLAN_OPT which is odd. Since it is checking extension for the > vport. > Why not set TUNNEL_VXLAN_OPT according to received packet header/metadata? Good point. I will change it to

Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-03 Thread Pravin Shelar
On Tue, Feb 3, 2015 at 1:18 PM, Thomas Graf wrote: > On 02/03/15 at 10:08am, Pravin Shelar wrote: >> On Fri, Jan 30, 2015 at 6:36 AM, Thomas Graf wrote: >> > + flags = TUNNEL_KEY; >> > + vxlan_port = vxlan_vport(vport); >> > + if (vxlan_port->exts & VXLAN_F_GBP) >> > +

Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-03 Thread Thomas Graf
On 02/03/15 at 10:08am, Pravin Shelar wrote: > On Fri, Jan 30, 2015 at 6:36 AM, Thomas Graf wrote: > > + flags = TUNNEL_KEY; > > + vxlan_port = vxlan_vport(vport); > > + if (vxlan_port->exts & VXLAN_F_GBP) > > + flags |= TUNNEL_VXLAN_OPT; > > > This does not allow G

Re: [ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-02-03 Thread Pravin Shelar
On Fri, Jan 30, 2015 at 6:36 AM, Thomas Graf wrote: > Upstream commit: > openvswitch: Support VXLAN Group Policy extension > > Introduces support for the group policy extension to the VXLAN virtual > port. The extension is disabled by default and only enabled if the user > has prov

[ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-01-30 Thread Thomas Graf
Upstream commit: openvswitch: Support VXLAN Group Policy extension Introduces support for the group policy extension to the VXLAN virtual port. The extension is disabled by default and only enabled if the user has provided the respective configuration. ovs-vsctl add-port br0