Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-02-22 Thread Rishi Bamba
Hi Ben, Greetings! This is in reference to the patch "ovs-ofctl: Implementation of eviction on the basis of Importance" which is under review. As per the last inputs received, the revised patch was sent on 11.02.2015 but haven't heard further about the same. Request to kindly provide further in

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-02-11 Thread Rishi Bamba
Hi Ben, > > This commit enables the eviction mechanism on the basis of > > importance as > > per the openflow specification 1.4. > > > > ovs-ofctl -O OpenFlow14 mod-table evict > > -Enable eviction on of . Eviction adds a mechanism > > enabling the switch to automatically eliminate entrie

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-02-11 Thread Rishi Bamba
From: Saloni Jain This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table evict -Enable eviction on of . Eviction adds a mechanism enabling the switch to automatically eliminate entries of lower i

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-30 Thread Ben Pfaff
On Fri, Jan 16, 2015 at 06:04:35PM +0530, Rishi Bamba wrote: > From: Saloni Jain > > This commit enables the eviction mechanism on the basis of importance as > per the openflow specification 1.4. > > ovs-ofctl -O OpenFlow14 mod-table evict > -Enable eviction on of . Eviction adds a mech

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-16 Thread Rishi Bamba
From: Saloni Jain This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table evict -Enable eviction on of . Eviction adds a mechanism enabling the switch to automatically eliminate entries of lower i

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-16 Thread Rishi Bamba
Hi Ben, > On Fri, Jan 02, 2015 at 05:41:58PM +0530, Saloni Jain wrote: > > Please find attached the updated patch for eviction feature, > > rebased with the latest ovs-master as on 02 Jan 2015. > > > > This patch has correct code indentation. Kindly review it and > > provide your comments/inputs.

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-13 Thread Ben Pfaff
On Fri, Jan 02, 2015 at 05:41:58PM +0530, Saloni Jain wrote: > Please find attached the updated patch for eviction feature, rebased with the > latest ovs-master as on 02 Jan 2015. > > This patch has correct code indentation. Kindly review it and provide your > comments/inputs. I can't get it to

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-02 Thread Saloni Jain
From: Saloni Jain This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table evict -Enable eviction on of . Eviction adds a mechanism  enabling the switch to automatically eliminate entries of lower  i

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-02 Thread Saloni Jain
Hi Ben, Please find attached the updated patch for eviction feature, rebased with the latest ovs-master as on 02 Jan 2015. This patch has correct code indentation. Kindly review it and provide your comments/inputs. Thanks and Regards, Saloni Jain Tata Consultancy Services Mailto: saloni.j...

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-12-31 Thread Ben Pfaff
On Fri, Dec 26, 2014 at 05:22:42PM +0530, Saloni Jain wrote: > There have been some changes in the ovs-master code, so we have > rebased our eviction patch in accordance to that. > > Please find attached the updated patch for eviction feature, rebased > with the latest ovs-master as on 26 Dec 2014

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-12-26 Thread Saloni Jain
From: Saloni Jain This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table evict -Enable eviction on of . Eviction adds a mechanism  enabling the switch to automatically eliminate entries of lower  i

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-12-26 Thread Saloni Jain
Hi Ben/Team, There have been some changes in the ovs-master code, so we have rebased our eviction patch in accordance to that. Please find attached the updated patch for eviction feature, rebased with the latest ovs-master as on 26 Dec 2014. Kindly review it and provide your inputs/comments if

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-12-11 Thread Saloni Jain
Hi Ben, Thanks for your reply. We have applied this patch on the latest ovs master branch and it was successful. Due to difference in mail server, the patch got corrupted. The patch present in ovs-dev forum (dated 27 Nov 2014) is also successfully applied. Attaching the patch with this mail f

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-12-11 Thread Ben Pfaff
On Thu, Nov 27, 2014 at 05:09:34PM +0530, Saloni Jain wrote: > From: Saloni Jain > > This commit enables the eviction mechanism on the basis of importance as > per the openflow specification 1.4. > > ovs-ofctl -O OpenFlow14 mod-table evict > -Enable eviction on of . Eviction adds a mech

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-12-10 Thread Saloni Jain
n Pfaff" , dev@openvswitch.org From: Saloni Jain/DEL/TCS Date: 12/04/2014 05:47PM Cc: Deepankar Gupta/DEL/TCS@TCS, Partha Datta/DEL/TCS@TCS Subject: Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance Hi Ben/Team, Could you please review the patch "[PATCH]

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-12-04 Thread Saloni Jain
tch.org, Deepankar Gupta , Partha Datta Subject: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance From: Saloni Jain This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table evict

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-27 Thread Saloni Jain
From: Saloni Jain This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table evict -Enable eviction on of . Eviction adds a mechanism  enabling the switch to automatically eliminate entries of lower  i

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-27 Thread Saloni Jain
Hi Ben, We are sending the new patch containing the suggested changes. The new patch also has some changes related to table-mod config properties. Kindly review and provide your comments. Thanks and Regards, Saloni Jain Tata Consultancy Services Mailto: saloni.j...@tcs.com Website: http://www

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-26 Thread Saloni Jain
Hi Ben, >ofptype_decode() and related functions check that the length of a >message agrees with the specification given in enum ofpraw in >ofp-msgs.h, so there is no need to do that again here. Thanks for the information, we will update it and will share the new patch. Thanks and Regards, Salon

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-25 Thread Ben Pfaff
On Fri, Nov 21, 2014 at 03:13:40PM +0530, Saloni Jain wrote: > >There is no need for this code in handle_table_desc_request() because > >higher-level code has already checked these properties for > >correctness: > >    ofpbuf_use_const(&msg, request, ntohs(request->length)); > >   ofpraw_pull_asser

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-21 Thread Rishi Bamba
From: Saloni Jain This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table evict -Enable eviction on of . Eviction adds a mechanism  enabling the switch to automatically eliminate entries of lower  i

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-21 Thread Saloni Jain
Hi Team, Please ignore previous mail for the patch " [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance" containing text "undefined". Due to some mail server problem, the patch was not sent correctly. We will resend the patch from "ris

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-21 Thread Saloni Jain
undefined =-=-= Notice: The information contained in this e-mail message and/or attachments to it may contain confidential or privileged information. If you are not the intended recipient, any dissemination, use, review, distribution, printing or copying of the information c

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-21 Thread Saloni Jain
undefined =-=-= Notice: The information contained in this e-mail message and/or attachments to it may contain confidential or privileged information. If you are not the intended recipient, any dissemination, use, review, distribution, printing or copying of the information c

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-21 Thread Saloni Jain
Hi Ben, Thank you for reviewing the patch. >"sparse" reported these warnings: All the sparse warnings have been resolved >The config field in a table description is a collection of bit-fields, >but some of this code, such as ofp_print_table_config() and >ofputil_append_table_desc_reply(), treat

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-11 Thread Ben Pfaff
On Fri, Nov 07, 2014 at 12:31:16PM +0530, Saloni Jain wrote: > Also attaching the patch for your reference. Thank you for the patch. I have some comments. "sparse" reported these warnings: ../lib/ofp-util.c:77:17: warning: non-ANSI function declaration of function 'get_ovsprop_map' ../lib/ofp-

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-10 Thread Ben Pfaff
On Fri, Nov 07, 2014 at 12:31:16PM +0530, Saloni Jain wrote: > Also attaching the patch for your reference. The attached patch applies, thanks. I will review it. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-06 Thread Saloni Jain
Hi Ben, >"git am" tells me "fatal: corrupt patch at line 21".  Please try to send >the patch to yourself; if you can apply it with "git am", then send it >the same way to the mailing list. "[PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance" sent on Nov 5,2014 has been succ

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-06 Thread Ben Pfaff
On Wed, Nov 05, 2014 at 06:33:22PM +0530, Saloni Jain wrote: > From: Saloni Jain > > This commit enables the eviction mechanism on the basis of importance as > per the openflow specification 1.4. > > ovs-ofctl -O OpenFlow14 mod-table evict > Enable eviction on of . Eviction adds a mecha

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-05 Thread Ben Pfaff
On Wed, Nov 05, 2014 at 06:28:13PM +0530, Saloni Jain wrote: > Hi Ben, > > The second version of the "[PATCH] ovs-ofctl:To set importance of a rule for > eviction(OF14)" has been submitted today - 5 Nov,2014 for review. > > We will also be submitting "[PATCH] ovs-ofctl: Implementation of evicti

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-05 Thread Saloni Jain
From: Saloni Jain This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table evict Enable eviction on of . Eviction adds a mechanism enabling the switch to automatically eliminate entries of lower impo

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-05 Thread Saloni Jain
From: Ben Pfaff Sent by: "dev" Date: 11/03/2014 09:23PM Cc: dev@openvswitch.org, deepankar.gu...@tcs.com, partha.da...@tcs.com Subject: Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance On Mon, Nov 03, 2014 at 04:55:05PM +0530, hiteshi.ma...@tcs.c

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-03 Thread Ben Pfaff
On Mon, Nov 03, 2014 at 04:55:05PM +0530, hiteshi.ma...@tcs.com wrote: > Kindly apply following 5 patches before applying patch for eviction: > [PATCH 1/5] ovs-ofctl:To set importance of a rule for eviction(OF14) > [PATCH 2/5] ovs-ofctl:Changes made to DESIGN and addedtest cases(OF14) > [PA

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-03 Thread Ben Pfaff
On Mon, Nov 03, 2014 at 05:48:52PM +0530, Hiteshi Madan wrote: > > From: root Please use a real name and email address. > This commit enables the eviction mechanism on the basis of importance as > per the openflow specification 1.4. > > ovs-ofctl mod-table evict > Enable eviction on o

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-03 Thread Hiteshi Madan
e: 11/03/2014 05:03PM Cc: deepankar.gu...@tcs.com, partha.da...@tcs.com Subject: Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance Hi Team, Kindly apply following 5 patches before applying patch for eviction: [PATCH 1/5] ovs-ofctl:To set importance of a rule for

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-03 Thread hiteshi . madan
Hi Team, Kindly apply following 5 patches before applying patch for eviction: [PATCH 1/5] ovs-ofctl:To set importance of a rule for eviction(OF14) [PATCH 2/5] ovs-ofctl:Changes made to DESIGN and added test cases(OF14) [PATCH 3/5] ovs-ofctl:Enhanced diff-flows & replace-flows(OF14) [PATCH 4/5

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-03 Thread Hiteshi Madan
From: root This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl mod-table evict Enable eviction on of . Eviction adds a mechanism enabling the switch to automatically eliminate entries of lower importance to make space for newe