Re: [ovs-dev] [PATCH] ovs-ofctl: Don't rely on stat() to check unix sockets.

2012-11-20 Thread Ben Pfaff
Let's leave it as-is then. On Tue, Nov 20, 2012 at 11:20:21AM -0800, Ethan Jackson wrote: > I can't seem to get it to produce an ENOTDIR in my testing. At least on > Linux and ESX, it seems to always give me an ENOENT. I could add it as > a precaution if you feel strongly about it. Thoughts? >

Re: [ovs-dev] [PATCH] ovs-ofctl: Don't rely on stat() to check unix sockets.

2012-11-20 Thread Ethan Jackson
I can't seem to get it to produce an ENOTDIR in my testing. At least on Linux and ESX, it seems to always give me an ENOENT. I could add it as a precaution if you feel strongly about it. Thoughts? Ethan On Tue, Nov 20, 2012 at 9:18 AM, Ben Pfaff wrote: > On Tue, Nov 20, 2012 at 09:14:02AM -

Re: [ovs-dev] [PATCH] ovs-ofctl: Don't rely on stat() to check unix sockets.

2012-11-20 Thread Ben Pfaff
On Tue, Nov 20, 2012 at 09:14:02AM -0800, Ben Pfaff wrote: > On Mon, Nov 19, 2012 at 05:48:10PM -0800, Ethan Jackson wrote: > > ESX supports unix sockets, but they don't manifest themselves in > > file system like they do on Linux. Instead of using stat to check > > if a unix socket exist, this pa

Re: [ovs-dev] [PATCH] ovs-ofctl: Don't rely on stat() to check unix sockets.

2012-11-20 Thread Ben Pfaff
On Mon, Nov 19, 2012 at 05:48:10PM -0800, Ethan Jackson wrote: > ESX supports unix sockets, but they don't manifest themselves in > file system like they do on Linux. Instead of using stat to check > if a unix socket exist, this patch simply tries to open it instead. > > Signed-off-by: Ethan Jack

[ovs-dev] [PATCH] ovs-ofctl: Don't rely on stat() to check unix sockets.

2012-11-19 Thread Ethan Jackson
ESX supports unix sockets, but they don't manifest themselves in file system like they do on Linux. Instead of using stat to check if a unix socket exist, this patch simply tries to open it instead. Signed-off-by: Ethan Jackson --- lib/stream-unix.c |1 - utilities/ovs-ofctl.c | 40 ++