Let's leave it as-is then.
On Tue, Nov 20, 2012 at 11:20:21AM -0800, Ethan Jackson wrote: > I can't seem to get it to produce an ENOTDIR in my testing. At least on > Linux and ESX, it seems to always give me an ENOENT. I could add it as > a precaution if you feel strongly about it. Thoughts? > > Ethan > > > On Tue, Nov 20, 2012 at 9:18 AM, Ben Pfaff <b...@nicira.com> wrote: > > > On Tue, Nov 20, 2012 at 09:14:02AM -0800, Ben Pfaff wrote: > > > On Mon, Nov 19, 2012 at 05:48:10PM -0800, Ethan Jackson wrote: > > > > ESX supports unix sockets, but they don't manifest themselves in > > > > file system like they do on Linux. Instead of using stat to check > > > > if a unix socket exist, this patch simply tries to open it instead. > > > > > > > > Signed-off-by: Ethan Jackson <et...@nicira.com> > > > > > > In stream-unix.c, would you mind reducing the VLOG_WARN to a VLOG_DBG > > > rather than just dropping it? > > > > > > Otherwise I'm happy with this. Thank you! > > > > Hmm, looking at > > http://pubs.opengroup.org/onlinepubs/9699919799/functions/connect.html > > I wonder whether we should ignore any other errors. Maybe ENOTDIR? > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
