Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-04 Thread Numan Siddique
On 12/04/2015 01:47 PM, Joe Stringer wrote: > On 3 December 2015 at 23:49, Numan Siddique wrote: >> On 12/04/2015 12:39 PM, Justin Pettit wrote: On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: > Before refactoring the

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-04 Thread Joe Stringer
On 3 December 2015 at 23:49, Numan Siddique wrote: > On 12/04/2015 12:39 PM, Justin Pettit wrote: >>> On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: >>> >>> On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we >

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Numan Siddique
On 12/04/2015 12:39 PM, Justin Pettit wrote: >> On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: >> >> On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: >>> Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we >>> would use a sequence to see if anything changed in NB d

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 23:09, Justin Pettit wrote: > >> On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: >> >> On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: >>> Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we >>> would use a sequence to see if anything changed

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Justin Pettit
> On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: > > On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: >> Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we >> would use a sequence to see if anything changed in NB database to >> compute and notify the SB database

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Ben Pfaff
On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: > Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we > would use a sequence to see if anything changed in NB database to > compute and notify the SB database, and vice versa. This logic got > dropped with the refact

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Thadeu Lima de Souza Cascardo
On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: > Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we > would use a sequence to see if anything changed in NB database to > compute and notify the SB database, and vice versa. This logic got > dropped with the refact

[ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Joe Stringer
Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we would use a sequence to see if anything changed in NB database to compute and notify the SB database, and vice versa. This logic got dropped with the refactor, causing a testsuite failure in the ovn-sbctl test. Reintroduce the