On 12/04/2015 12:39 PM, Justin Pettit wrote: >> On Dec 3, 2015, at 10:55 PM, Ben Pfaff <b...@ovn.org> wrote: >> >> On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: >>> Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we >>> would use a sequence to see if anything changed in NB database to >>> compute and notify the SB database, and vice versa. This logic got >>> dropped with the refactor, causing a testsuite failure in the ovn-sbctl >>> test. Reintroduce the IDL sequence number checking. >>> >>> Fixes: 331e7aefe1c6 ("ovn-northd: Refactor main loop to use ovsdb_idl_loop_* >>> functions") >>> Suggested-by: Numan Siddique <nusid...@redhat.com> >>> Signed-off-by: Joe Stringer <j...@ovn.org> >> Acked-by: Ben Pfaff <b...@ovn.org> > I pushed this myself so we can branch for 2.5 with your Acked-by and > Cascardo's Tested-by. Thanks Justin.
I see the "send error: Broken pipe" warn logs [1] in the file - tests/testsuite.dir/1713/ovn-nb/ovsdb-server.log when I run the test case [ovn -- 3 HVs, 3 LS, 3 lports/LS, 1 LR] at tests/ovn.at (Line no 842) and make it fail at the end by putting "AT_CHECK([echo hi], [1])" at line 1106 before clean up. I tested this with out the refactored ovn-northd main loop code and I still see the same logs in the ovsdb-server.log Not sure what is the cause of this. May be the issue is somewhere else. Also with this patch, I can see the issue [2] again. I guess its not a major issue. [1] - 2015-12-04T07:16:30.071Z|00001|vlog|INFO|opened log file /home/nsiddique/workspace_cpp/openvswitch/src/ovs_numan/tests/testsuite.dir/1713/ovn-nb/ovsdb-server.log 2015-12-04T07:16:30.076Z|00002|ovsdb_server|INFO|ovsdb-server (Open vSwitch) 2.4.90 2015-12-04T07:16:30.151Z|00003|jsonrpc|WARN|unix: send error: Broken pipe 2015-12-04T07:16:30.151Z|00004|reconnect|WARN|unix: connection dropped (Broken pipe) 2015-12-04T07:16:30.157Z|00005|jsonrpc|WARN|unix: send error: Broken pipe 2015-12-04T07:16:30.157Z|00006|reconnect|WARN|unix: connection dropped (Broken pipe) 2015-12-04T07:16:30.162Z|00007|jsonrpc|WARN|unix: send error: Broken pipe 2015-12-04T07:16:30.162Z|00008|reconnect|WARN|unix: connection dropped (Broken pipe) 2015-12-04T07:16:30.176Z|00009|jsonrpc|WARN|unix: send error: Broken pipe 2015-12-04T07:16:30.176Z|00010|reconnect|WARN|unix: connection dropped (Broken pipe) 2015-12-04T07:16:30.188Z|00011|jsonrpc|WARN|unix: send error: Broken pipe 2015-12-04T07:16:30.188Z|00012|reconnect|WARN|unix: connection dropped (Broken pipe) 2015-12-04T07:16:30.242Z|00013|reconnect|WARN|unix: connection dropped (Broken pipe) 2015-12-04T07:16:30.250Z|00014|reconnect|WARN|unix: connection dropped (Broken pipe) 2015-12-04T07:16:30.303Z|00015|reconnect|WARN|unix: connection dropped (Broken pipe) 2015-12-04T07:16:30.336Z|00016|reconnect|WARN|unix: connection dropped (Broken pipe) 2015-12-04T07:16:40.084Z|00017|memory|INFO|6084 kB peak resident set size after 10.0 seconds 2015-12-04T07:16:40.084Z|00018|memory|INFO|cells:528 monitors:1 sessions:1 2015-12-04T07:16:53.106Z|00019|fatal_signal|WARN|terminating with signal 15 (Terminated) [2] - http://openvswitch.org/pipermail/discuss/2015-November/019445.html Thanks Numan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev