Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Unmask mark when used for tunnels.

2013-08-01 Thread Jesse Gross
Thanks, I added a comment and pushed it. On Thu, Aug 1, 2013 at 6:24 PM, Justin Pettit wrote: > Looks good. It might be nice to add a comment stating that only tunnel uses > mark right now, since it's not inherent that mark's are specific to tunnels. > It might act as a good reminder later if

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Unmask mark when used for tunnels.

2013-08-01 Thread Justin Pettit
Looks good. It might be nice to add a comment stating that only tunnel uses mark right now, since it's not inherent that mark's are specific to tunnels. It might act as a good reminder later if/when we use mark other places. Acked-by: Justin Pettit Thanks! --Justin On Aug 1, 2013, at 1:36

[ovs-dev] [PATCH] ofproto-dpif-xlate: Unmask mark when used for tunnels.

2013-08-01 Thread Jesse Gross
The tunnel lookup uses the skb_mark as part of the port find process but it isn't unmasked along with the other fields. This adds it to the list of significant fields. Signed-off-by: Jesse Gross --- ofproto/ofproto-dpif-xlate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ofproto/ofproto-