Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix out-of-scope use of stack memory.

2014-10-10 Thread Alex Wang
> > > Found by running ovs on RHEL7. > > > > Signed-off-by: Alex Wang > > It's not obvious to me where the flow escapes from the loop, but the > fix looks fine. > Sure, in upcall_receive(), the &flow is assigned to upcall->flow, upcall->flow is referred several times in handle_upcalls(), And t

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix out-of-scope use of stack memory.

2014-10-10 Thread Ben Pfaff
On Fri, Oct 10, 2014 at 03:02:09PM -0700, Alex Wang wrote: > Commit cc377352d (ofproto: Reorganize in preparation for direct > dpdk upcalls.) introduced the bug that keeps reference to 'struct > flow' defined on the stack inside while loop when running out of > the scope. This causes strange bug l

[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix out-of-scope use of stack memory.

2014-10-10 Thread Alex Wang
Commit cc377352d (ofproto: Reorganize in preparation for direct dpdk upcalls.) introduced the bug that keeps reference to 'struct flow' defined on the stack inside while loop when running out of the scope. This causes strange bug like wrong mask extraction when the part of memory is corrupted, and