On Fri, Oct 10, 2014 at 03:02:09PM -0700, Alex Wang wrote: > Commit cc377352d (ofproto: Reorganize in preparation for direct > dpdk upcalls.) introduced the bug that keeps reference to 'struct > flow' defined on the stack inside while loop when running out of > the scope. This causes strange bug like wrong mask extraction > when the part of memory is corrupted, and could lead to even > more serious bug/crash. > > This commit fixes the above issue by defining an array of the > 'struct flow's on the function stack. > > Found by running ovs on RHEL7. > > Signed-off-by: Alex Wang <al...@nicira.com>
It's not obvious to me where the flow escapes from the loop, but the fix looks fine. Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
