Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-27 Thread Andy Zhou
This sounds attractive. Let's talk about how it should look like in more detail. On Wed, Mar 27, 2013 at 4:18 PM, Ben Pfaff wrote: > On Wed, Mar 27, 2013 at 04:01:57PM -0700, Ethan Jackson wrote: > > I had a question about this. Did we consider simply using coverage > > counters? We could ext

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-27 Thread Ben Pfaff
On Wed, Mar 27, 2013 at 04:01:57PM -0700, Ethan Jackson wrote: > I had a question about this. Did we consider simply using coverage > counters? We could extend them to report a rate. This would be > useful more generally. Andy and I talked about this briefly this afternoon. I think that it wou

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-27 Thread Ethan Jackson
I had a question about this. Did we consider simply using coverage counters? We could extend them to report a rate. This would be useful more generally. Ethan On Wed, Mar 27, 2013 at 3:59 PM, Andy Zhou wrote: > This is fine. Thanks > > > On Wednesday, March 27, 2013, Ben Pfaff wrote: >> >> On

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-27 Thread Ben Pfaff
Thanks, applied to master. On Wed, Mar 27, 2013 at 03:59:03PM -0700, Andy Zhou wrote: > This is fine. Thanks > > On Wednesday, March 27, 2013, Ben Pfaff wrote: > > > On Mon, Mar 25, 2013 at 07:49:13PM -0700, Andy Zhou wrote: > > > This patch adds more flow related stats to the output of > > > "o

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-27 Thread Andy Zhou
This is fine. Thanks On Wednesday, March 27, 2013, Ben Pfaff wrote: > On Mon, Mar 25, 2013 at 07:49:13PM -0700, Andy Zhou wrote: > > This patch adds more flow related stats to the output of > > "ovs-appctl dpif/show". Specifically, the follow information > > are added per ofproto: > > > > - Max

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-27 Thread Ben Pfaff
On Mon, Mar 25, 2013 at 07:49:13PM -0700, Andy Zhou wrote: > This patch adds more flow related stats to the output of > "ovs-appctl dpif/show". Specifically, the follow information > are added per ofproto: > > - Max flow table size > - Average flow table size > - Average flow table add rate > - A

[ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-25 Thread Andy Zhou
This is the full patch --- This patch adds more flow related stats to the output of "ovs-appctl dpif/show". Specifically, the follow information are added per ofproto: - Max flow table size - Average flow table size - Average flow table add rate - Average flow table delete rate - Average flow en

[ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-25 Thread Andy Zhou
This patch adds more flow related stats to the output of "ovs-appctl dpif/show". Specifically, the follow information are added per ofproto: - Max flow table size - Average flow table size - Average flow table add rate - Average flow table delete rate - Average flow entry life in milliseconds Fe

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-25 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 03:24:15PM -0700, Andy Zhou wrote: > This patch adds more flow related stats to the output of > "ovs-appctl dpif/show". Specifically, the follow information > are added per ofproto: > > - Max flow table size > - Average flow table size > - Average flow table add rate > - A

[ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-22 Thread Andy Zhou
This patch adds more flow related stats to the output of "ovs-appctl dpif/show". Specifically, the follow information are added per ofproto: - Max flow table size - Average flow table size - Average flow table add rate - Average flow table delete rate - Average flow entry life in milliseconds Fe

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-22 Thread Andy Zhou
Ben, Thanks for the review. I will send out the patch again after fixing all issues you mentioned in the review. On Fri, Mar 22, 2013 at 12:51 PM, Ben Pfaff wrote: > On Mon, Mar 18, 2013 at 05:28:04PM -0700, Andy Zhou wrote: > > This patch adds more flow related stats to the output of > > "ovs-

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-22 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 05:28:04PM -0700, Andy Zhou wrote: > This patch adds more flow related stats to the output of > "ovs-appctl dpif/show". Specifically, the follow information > are added per ofproto: > > - Max flow table size > - Average flow table size > - Average flow table add rate > - A

[ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-18 Thread Andy Zhou
This patch adds more flow related stats to the output of "ovs-appctl dpif/show". Specifically, the follow information are added per ofproto: - Max flow table size - Average flow table size - Average flow table add rate - Average flow table delete rate - Average flow entry life in milliseconds Fe