On Mon, Mar 25, 2013 at 07:49:13PM -0700, Andy Zhou wrote:
> This patch adds more flow related stats to the output of
> "ovs-appctl dpif/show".  Specifically, the follow information
> are added per ofproto:
> 
> - Max flow table size
> - Average flow table size
> - Average flow table add rate
> - Average flow table delete rate
> - Average flow entry life in milliseconds
> 
> Feature #15366
> 
> Signed-off-by: Andy Zhou <az...@nicira.com>

I'm OK with this.

Do you mind if I change the comment on exp_mavg() to:

/* Compute exponentially weighted moving average, adding 'new' as the newest,
 * most heavily weighted element.  'base' designates the rate of decay: after
 * 'base' further updates, 'new''s weight in the EWMA decays to about 1/e
 * (about .37). */

I find this a more satisfying explanation.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to