Re: [ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ethan Jackson
Thanks, I've pushed this. Ethan On Wed, Jan 11, 2012 at 11:28, Ben Pfaff wrote: > Thanks, I'm happy with this. > > On Wed, Jan 11, 2012 at 11:27:00AM -0800, Ethan Jackson wrote: >> I agree this is a bit subtle.  Here's an updated version of the patch. >> >> --- >> A "packet out" ordinarily isn'

Re: [ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ben Pfaff
Thanks, I'm happy with this. On Wed, Jan 11, 2012 at 11:27:00AM -0800, Ethan Jackson wrote: > I agree this is a bit subtle. Here's an updated version of the patch. > > --- > A "packet out" ordinarily isn't accounted to any OpenFlow rule, > because its actions come directly from the controller in

[ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ethan Jackson
I agree this is a bit subtle. Here's an updated version of the patch. --- A "packet out" ordinarily isn't accounted to any OpenFlow rule, because its actions come directly from the controller instead of from an OpenFlow rule. However, any "resubmit" actions or output to OFPP_TABLE within the set

Re: [ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ben Pfaff
On Tue, Jan 10, 2012 at 08:19:17PM -0800, Ethan Jackson wrote: > Reported-by: Jesse Gross > Signed-off-by: Ethan Jackson > --- > > Jesse tested this, I've only compiled it. The patch looks good, but it took me a while to understand the rationale here. Let me add to your changelog (or you can e

[ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-10 Thread Ethan Jackson
Reported-by: Jesse Gross Signed-off-by: Ethan Jackson --- Jesse tested this, I've only compiled it. --- ofproto/ofproto-dpif.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index f5280ff..bcdb1d3 100644 --- a