Re: [ovs-dev] [PATCH] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-03 Thread Justin Pettit
On Aug 3, 2013, at 12:23 AM, Ben Pfaff wrote: > On Sat, Aug 03, 2013 at 12:22:09AM -0700, Justin Pettit wrote: >> On Aug 2, 2013, at 11:07 PM, Ben Pfaff wrote: >> >>> On Fri, Aug 02, 2013 at 10:53:40PM -0700, Justin Pettit wrote: > In the case where we do emit a "set" action, we un-wildcard

Re: [ovs-dev] [PATCH] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-03 Thread Ben Pfaff
On Sat, Aug 03, 2013 at 12:22:09AM -0700, Justin Pettit wrote: > On Aug 2, 2013, at 11:07 PM, Ben Pfaff wrote: > > > On Fri, Aug 02, 2013 at 10:53:40PM -0700, Justin Pettit wrote: > >>> In the case where we do emit a "set" action, we un-wildcard not just the > >>> single field but all the fields

Re: [ovs-dev] [PATCH] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-03 Thread Justin Pettit
On Aug 2, 2013, at 11:07 PM, Ben Pfaff wrote: > On Fri, Aug 02, 2013 at 10:53:40PM -0700, Justin Pettit wrote: >>> In the case where we do emit a "set" action, we un-wildcard not just the >>> single field but all the fields that have to be set in the datapath in >>> one go. Is that necessary her

Re: [ovs-dev] [PATCH] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-02 Thread Ben Pfaff
On Fri, Aug 02, 2013 at 10:53:40PM -0700, Justin Pettit wrote: > > In the case where we do emit a "set" action, we un-wildcard not just the > > single field but all the fields that have to be set in the datapath in > > one go. Is that necessary here? My initial thought is "no" but I want > > to m

Re: [ovs-dev] [PATCH] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-02 Thread Justin Pettit
On Aug 2, 2013, at 10:08 PM, Ben Pfaff wrote: > I think that OFPACT_STRIP_VLAN and OFPACT_PUSH_VLAN also need updated > treatment. Fixed. > Does nxm_execute_reg_move() need to un-wildcard the dest field too? > Seems so. How about nxm_execute_stack_pop()? Agreed. > How about compose_mpls_pus

Re: [ovs-dev] [PATCH] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-02 Thread Ben Pfaff
On Fri, Aug 02, 2013 at 09:33:27PM -0700, Justin Pettit wrote: > The ODP library has an optimization to not set a header if the field was > not changed, regardless of whether an action to set the field was > present. That library is also responsible for un-wildcarding fields > that are bieng modif

[ovs-dev] [PATCH] ofproto-dpif: Always un-wildcard fields that are being set.

2013-08-02 Thread Justin Pettit
The ODP library has an optimization to not set a header if the field was not changed, regardless of whether an action to set the field was present. That library is also responsible for un-wildcarding fields that are bieng modified. This leads to a problem where a packet matches a flow that update