On Aug 2, 2013, at 10:08 PM, Ben Pfaff <b...@nicira.com> wrote: > I think that OFPACT_STRIP_VLAN and OFPACT_PUSH_VLAN also need updated > treatment.
Fixed. > Does nxm_execute_reg_move() need to un-wildcard the dest field too? > Seems so. How about nxm_execute_stack_pop()? Agreed. > How about compose_mpls_push_action(), compose_mpls_pop_action(), and > compose_set_mpls_ttl_action)? I think the push and pop are already handled. Let me know if you think there's still a problem. I agree that the TTL action should be updated. > nxm_reg_load(), used by OFPACT_MULTIPATH and OFPACT_BUNDLE? Good catch. > In the case where we do emit a "set" action, we un-wildcard not just the > single field but all the fields that have to be set in the datapath in > one go. Is that necessary here? My initial thought is "no" but I want > to make sure that you have also considered that. I think we need to do that, since we're overwriting all those fields. Isn't it essentially the same issue that unless we un-wildcard it, we'll overwrite other header fields regardless of their value based on too loose a megaflow? I'll send out v2 in a moment that addresses the issues above. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
