Re: [ovs-dev] [PATCH] ofproto: Warn about excessive rule counts in OpenFlow tables.

2014-09-17 Thread Ben Pfaff
I'm OK with it, I'll take your word for it that it's a better approach. Acked-by: Ben Pfaff On Wed, Sep 17, 2014 at 03:04:11PM -0700, Ethan Jackson wrote: > I think something like that would be useful. However, once the number > of flows gets really high, I like the idea of having something tha

Re: [ovs-dev] [PATCH] ofproto: Warn about excessive rule counts in OpenFlow tables.

2014-09-17 Thread Ethan Jackson
I think something like that would be useful. However, once the number of flows gets really high, I like the idea of having something that's a bit more in your face. When debugging these things, people tend to tail the OVS log file instead of grepping for warnings and error messages. I think some

Re: [ovs-dev] [PATCH] ofproto: Warn about excessive rule counts in OpenFlow tables.

2014-09-17 Thread Ben Pfaff
On Wed, Sep 17, 2014 at 01:25:19PM -0700, Ethan Jackson wrote: > Frequently we've run into controller bugs which result in hundreds of > thousands, or even millions of rules being installed in an OpenFlow > table. This isn't something trouble-shooters naturally think of to > check for, so it's nic

[ovs-dev] [PATCH] ofproto: Warn about excessive rule counts in OpenFlow tables.

2014-09-17 Thread Ethan Jackson
Frequently we've run into controller bugs which result in hundreds of thousands, or even millions of rules being installed in an OpenFlow table. This isn't something trouble-shooters naturally think of to check for, so it's nice to have a low rate warning message to hint at the potential problem.