Re: [ovs-dev] [PATCH] ofproto: Set-Field VLAN_VID should not check OFPVID_PRESENT

2013-11-21 Thread Ben Pfaff
This was a big problem at the ONF plugfest a few weeks ago. None of the switches and controllers agreed on whether OFPVID_PRESENT should be optional or mandatory or forbidden. Perhaps a clarification to the standard is forthcoming. On Fri, Nov 22, 2013 at 01:35:40AM +0100, Marco Canini wrote: >

Re: [ovs-dev] [PATCH] ofproto: Set-Field VLAN_VID should not check OFPVID_PRESENT

2013-11-21 Thread Marco Canini
Ah, I had missed 1.3.3. Based on that, my patch is wrong. I had checked on 1.2, 1.3.2 and 1.4.0 and none of them contains that information. So, yes, that text is missing in 1.4. On Fri, Nov 22, 2013 at 1:12 AM, Jarno Rajahalme wrote: > > On Nov 21, 2013, at 3:47 PM, Marco Canini wrote: > > > C

Re: [ovs-dev] [PATCH] ofproto: Set-Field VLAN_VID should not check OFPVID_PRESENT

2013-11-21 Thread Jarno Rajahalme
On Nov 21, 2013, at 3:47 PM, Marco Canini wrote: > Currently set_field_from_openflow is checking that the OFPVID_PRESENT bit is > set for a set VLAN_VID action to be valid. > I am reading the OF specs 1.2, 1.3 and 1.4, and I cannot see any mentioning > of OFPVID_PRESENT being required in this

[ovs-dev] [PATCH] ofproto: Set-Field VLAN_VID should not check OFPVID_PRESENT

2013-11-21 Thread Marco Canini
Currently set_field_from_openflow is checking that the OFPVID_PRESENT bit is set for a set VLAN_VID action to be valid. I am reading the OF specs 1.2, 1.3 and 1.4, and I cannot see any mentioning of OFPVID_PRESENT being required in this context. OFPVID_PRESENT is used as a special VLAN_VID value fo