This was a big problem at the ONF plugfest a few weeks ago. None of the switches and controllers agreed on whether OFPVID_PRESENT should be optional or mandatory or forbidden. Perhaps a clarification to the standard is forthcoming.
On Fri, Nov 22, 2013 at 01:35:40AM +0100, Marco Canini wrote: > Ah, I had missed 1.3.3. Based on that, my patch is wrong. > > I had checked on 1.2, 1.3.2 and 1.4.0 and none of them contains that > information. So, yes, that text is missing in 1.4. > > > On Fri, Nov 22, 2013 at 1:12 AM, Jarno Rajahalme <jrajaha...@nicira.com>wrote: > > > > > On Nov 21, 2013, at 3:47 PM, Marco Canini <marco.can...@acm.org> wrote: > > > > > Currently set_field_from_openflow is checking that the OFPVID_PRESENT > > bit is set for a set VLAN_VID action to be valid. > > > I am reading the OF specs 1.2, 1.3 and 1.4, and I cannot see any > > mentioning of OFPVID_PRESENT being required in this context. OFPVID_PRESENT > > is used as a special VLAN_VID value for matching. > > > > > > > OpenFlow Specification 1.3.3 ( > > https://www.opennetworking.org/images/stories/downloads/sdn-resources/onf-specifications/openflow/openflow-spec-v1.3.3.pdf), > > p. 65: > > > > ?The value in the payload of the OXM TLV must be valid, in particular the > > OFPVID_PRESENT bit must be set in OXM_OF_VLAN_VID set-fi eld actions.? > > > > Haven?t checked 1.4 text, is this missing from there? > > > > Jarno > > > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
