Thanks for the review.
On Tue, Apr 02, 2013 at 09:27:12PM -0700, Andy Zhou wrote:
> Looks good.
>
> On Tuesday, April 2, 2013, Ben Pfaff wrote:
>
> > I spotted this in a case where I ran ovsdb-server, by hand, on an empty
> > database.
> >
> > Signed-off-by: Ben Pfaff >
> > ---
> > lib/memory.c
On Tue, Apr 02, 2013 at 09:33:46PM -0700, Justin Pettit wrote:
> On Apr 2, 2013, at 8:49 PM, Ben Pfaff wrote:
>
> > -if (want_report) {
> > +if (want_report && s.length > 0) {
>
> Isn't our style normally to do it like this?
>
> if (want_report && s.length) {
Is it? I'm OK with
On Apr 2, 2013, at 8:49 PM, Ben Pfaff wrote:
> -if (want_report) {
> +if (want_report && s.length > 0) {
Isn't our style normally to do it like this?
if (want_report && s.length) {
Otherwise, looks good.
--Justin
___
dev mailing li
Looks good.
On Tuesday, April 2, 2013, Ben Pfaff wrote:
> I spotted this in a case where I ran ovsdb-server, by hand, on an empty
> database.
>
> Signed-off-by: Ben Pfaff >
> ---
> lib/memory.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/memory.c b/lib/mem
I spotted this in a case where I ran ovsdb-server, by hand, on an empty
database.
Signed-off-by: Ben Pfaff
---
lib/memory.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/memory.c b/lib/memory.c
index 1babfe9..274f307 100644
--- a/lib/memory.c
+++ b/lib/memory.c
@
