On Tue, Apr 02, 2013 at 09:33:46PM -0700, Justin Pettit wrote:
> On Apr 2, 2013, at 8:49 PM, Ben Pfaff <b...@nicira.com> wrote:
>
> > - if (want_report) {
> > + if (want_report && s.length > 0) {
>
> Isn't our style normally to do it like this?
>
> if (want_report && s.length) {
Is it? I'm OK with that too.
> Otherwise, looks good.
Thanks.
Actually the one thing that occurred to me here is that we could discard
empty log messages in vlog itself. But... logging an empty message is
something weird, so maybe by itself that's worth logging. Anyway, I
ended up with the current patch.
I'll make the change you suggest in the morning and apply it.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
