Re: [ovs-dev] [PATCH] datapath-windows: Sample action support.

2016-06-01 Thread Sorin Vinturis
turis; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Sample action support. Beside moving the new functions from Random.h to Util.h, LGTM. > >+ > >+elem = OvsCreateQueueNlPacket(NlAttrData(userdataAttr), > >+ NlAttrGet

Re: [ovs-dev] [PATCH] datapath-windows: Sample action support.

2016-05-26 Thread Alin Serdean
Beside moving the new functions from Random.h to Util.h, LGTM. > >+ > >+elem = OvsCreateQueueNlPacket(NlAttrData(userdataAttr), > >+ NlAttrGetSize(userdataAttr), > > The existing code passes ŒuserdataAttr¹ as-is and not the payload. > Basically, it passes the

Re: [ovs-dev] [PATCH] datapath-windows: Sample action support.

2016-05-17 Thread Nithin Raju
in the refactoring. Can you pls. address that? -Original Message- From: dev on behalf of Sorin Vinturis Date: Saturday, April 16, 2016 at 11:03 AM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH] datapath-windows: Sample action support. >This patch adds support for sa

[ovs-dev] [PATCH] datapath-windows: Sample action support.

2016-04-16 Thread Sorin Vinturis
This patch adds support for sampling to the OVS extension. The following flow was used for generating sample actions: ovs-ofctl add-flow tcp:127.0.0.1: "actions=sample( probability=12345,collector_set_id=23456,obs_domain_id=34567, obs_point_id=45678)" Signed-off-by: Sorin Vinturis