Re: [ovs-dev] [PATCH] datapath: Use kfree_skb() only on error paths.

2011-10-21 Thread Ben Pfaff
On Fri, Oct 21, 2011 at 03:37:31PM -0700, Jesse Gross wrote: > On Fri, Oct 21, 2011 at 3:30 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > Acked-by: Jesse Gross Thank you, I pushed this. ___ dev mailing list dev@openvswitch.org http://openvswi

Re: [ovs-dev] [PATCH] datapath: Use kfree_skb() only on error paths.

2011-10-21 Thread Jesse Gross
On Fri, Oct 21, 2011 at 3:30 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] datapath: Use kfree_skb() only on error paths.

2011-10-21 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- datapath/datapath.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 10bf4b9..de2f76b 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -309,7 +309,7 @@ void dp_process_received_packe

Re: [ovs-dev] [PATCH] datapath: Use kfree_skb() only on error paths.

2011-10-21 Thread Ben Pfaff
On Thu, Oct 20, 2011 at 01:21:51PM -0700, Jesse Gross wrote: > On Wed, Oct 19, 2011 at 9:46 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > Acked-by: Jesse Gross I fixed up the one that this patch originally addressed as part of bug #7557, so I'm dropping this one. > > Arguably the call

Re: [ovs-dev] [PATCH] datapath: Use kfree_skb() only on error paths.

2011-10-20 Thread Jesse Gross
On Wed, Oct 19, 2011 at 9:46 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Jesse Gross > Arguably the call to dp_upcall() in dp_process_received_packet() > should also be followed by consume_skb() instead of kfree_skb(). Yes, it definitely should be (that one went in at the same t

[ovs-dev] [PATCH] datapath: Use kfree_skb() only on error paths.

2011-10-19 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- Arguably the call to dp_upcall() in dp_process_received_packet() should also be followed by consume_skb() instead of kfree_skb(). And I see that fragment() in vport-capwap.c uses kfree_skb() from its "out" label that is used for both success and failure paths. diff --