On Thu, Oct 20, 2011 at 01:21:51PM -0700, Jesse Gross wrote: > On Wed, Oct 19, 2011 at 9:46 PM, Ben Pfaff <b...@nicira.com> wrote: > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > Acked-by: Jesse Gross <je...@nicira.com>
I fixed up the one that this patch originally addressed as part of bug #7557, so I'm dropping this one. > > Arguably the call to dp_upcall() in dp_process_received_packet() > > should also be followed by consume_skb() instead of kfree_skb(). > > Yes, it definitely should be (that one went in at the same time as this one). I'll send out a separate patch. > > And I see that fragment() in vport-capwap.c uses kfree_skb() from > > its "out" label that is used for both success and failure paths. > > It's probably worth separating them out since it is easy enough. It was actually buggy, so I sent out a patch to fix the bug as the same time. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
