Re: [ovs-dev] [PATCH] datapath: Set vport in skb when executed from userspace.

2011-09-14 Thread Jesse Gross
On Tue, Sep 13, 2011 at 6:43 PM, Ben Pfaff wrote: > On Tue, Sep 13, 2011 at 04:43:32PM -0700, Jesse Gross wrote: >> +     if (flow->key.eth.in_port != USHRT_MAX) >> +             OVS_CB(packet)->vport = get_vport_protected(dp, >> +                                                     flow->key.eth.

Re: [ovs-dev] [PATCH] datapath: Set vport in skb when executed from userspace.

2011-09-13 Thread Ben Pfaff
On Tue, Sep 13, 2011 at 04:43:32PM -0700, Jesse Gross wrote: > + if (flow->key.eth.in_port != USHRT_MAX) > + OVS_CB(packet)->vport = get_vport_protected(dp, > + flow->key.eth.in_port); > + The nervous part of me would prefer "if (

Re: [ovs-dev] [PATCH] datapath: Set vport in skb when executed from userspace.

2011-09-13 Thread Pravin Shelar
On Tue, Sep 13, 2011 at 4:43 PM, Jesse Gross wrote: > Currently, the OVS_CB(skb)->vport member is never initialized for > packets coming from userspace.  This means that they can never be > sampled by sFlow and generally violates our principle that userspace > packets should be made to look the sa

[ovs-dev] [PATCH] datapath: Set vport in skb when executed from userspace.

2011-09-13 Thread Jesse Gross
Currently, the OVS_CB(skb)->vport member is never initialized for packets coming from userspace. This means that they can never be sampled by sFlow and generally violates our principle that userspace packets should be made to look the same as others. Signed-off-by: Jesse Gross --- datapath/data