On Tue, Sep 13, 2011 at 6:43 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Tue, Sep 13, 2011 at 04:43:32PM -0700, Jesse Gross wrote:
>> +     if (flow->key.eth.in_port != USHRT_MAX)
>> +             OVS_CB(packet)->vport = get_vport_protected(dp,
>> +                                                     flow->key.eth.in_port);
>> +
>
> The nervous part of me would prefer "if (flow->key.eth.in_port <
> DP_MAX_PORTS)", or similar, but I think that this is correct.

That's reasonable.  I made that change and pushed this to master and branch-1.2.

Thanks to both of you for the reviews.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to