Re: [ovs-dev] [PATCH] datapath: Refactor actions in terms of match fields.

2011-10-18 Thread Ethan Jackson
> Do you habitually run "make check" as root?  This causes tests to be > skipped, so I don't recommend it. I do the same thing, didn't realize it skips tests. I'll have to change it. Ethan > ___ > dev mailing list > dev@openvswitch.org > http://openvs

Re: [ovs-dev] [PATCH] datapath: Refactor actions in terms of match fields.

2011-10-18 Thread Ben Pfaff
On Tue, Oct 18, 2011 at 05:50:58PM -0700, Pravin Shelar wrote: > On Tue, Oct 18, 2011 at 3:47 PM, Jesse Gross wrote: > > You also need to update test 387: ofproto-dpif.at:83 ofproto-dpif - > > VLAN handling to account for the changed output. > > > right, vlan test was skipped in my make check. Do

Re: [ovs-dev] [PATCH] datapath: Refactor actions in terms of match fields.

2011-10-18 Thread Pravin Shelar
On Tue, Oct 18, 2011 at 3:47 PM, Jesse Gross wrote: > On Thu, Oct 13, 2011 at 3:23 PM, Pravin B Shelar wrote: >> Almost all current actions can be expressed in the form of >> push/pop/set , where field is one of the match fields. We can >> create three base actions and take a field. This has both

Re: [ovs-dev] [PATCH] datapath: Refactor actions in terms of match fields.

2011-10-18 Thread Ben Pfaff
On Tue, Oct 18, 2011 at 03:47:19PM -0700, Jesse Gross wrote: > On Thu, Oct 13, 2011 at 3:23 PM, Pravin B Shelar wrote: > > Almost all current actions can be expressed in the form of > > push/pop/set , where field is one of the match fields. We can > > create three base actions and take a field. Th

Re: [ovs-dev] [PATCH] datapath: Refactor actions in terms of match fields.

2011-10-18 Thread Jesse Gross
On Thu, Oct 13, 2011 at 3:23 PM, Pravin B Shelar wrote: > Almost all current actions can be expressed in the form of > push/pop/set , where field is one of the match fields. We can > create three base actions and take a field. This has both a nice > symmetry and avoids inconsistencies where we can

[ovs-dev] [PATCH] datapath: Refactor actions in terms of match fields.

2011-10-13 Thread Pravin B Shelar
Almost all current actions can be expressed in the form of push/pop/set , where field is one of the match fields. We can create three base actions and take a field. This has both a nice symmetry and avoids inconsistencies where we can match on the vlan TPID but not set it. Following patch converts