On Tue, Oct 18, 2011 at 03:47:19PM -0700, Jesse Gross wrote: > On Thu, Oct 13, 2011 at 3:23 PM, Pravin B Shelar <pshe...@nicira.com> wrote: > > Almost all current actions can be expressed in the form of > > push/pop/set <field>, where field is one of the match fields. We can > > create three base actions and take a field. This has both a nice > > symmetry and avoids inconsistencies where we can match on the vlan > > TPID but not set it. > > Following patch converts all actions to this new format. > > > > Signed-off-by: Pravin B Shelar <pshe...@nicira.com> > > Bug #7115 > > Overall, this looks pretty good to me. I have a few miscellaneous > comments but in general I like the structure of it. Ben, can you take > a look at it as well (although you might as well wait until Pravin has > had a chance to address my comments here)?
Yes, I'll gladly do a quick review at that point. Thanks guys. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
