Thank you for pointing this out. Please disregard the patch.
On Fri, Jun 21, 2013 at 10:12 AM, Jesse Gross wrote:
> That sounds right to me.
>
> On Fri, Jun 21, 2013 at 10:06 AM, Andy Zhou wrote:
> > You are right.
> >
> > The user space code needs to distinguish between two cases:
> > 1) The
That sounds right to me.
On Fri, Jun 21, 2013 at 10:06 AM, Andy Zhou wrote:
> You are right.
>
> The user space code needs to distinguish between two cases:
> 1) The entire mask attribute is missing, then the entire key is exact match.
> 2) The mask attribute is there, then the missing key attrib
You are right.
The user space code needs to distinguish between two cases:
1) The entire mask attribute is missing, then the entire key is exact
match.
2) The mask attribute is there, then the missing key attributes should be
treated as wildcarded fields.
It seems we don't need this patch, but ma
It doesn't really make sense that userspace would interpret a missing
attribute as exact match because when the flow is installed a missing
attribute means that it is wildcarded. Therefore, if you echoed back
the exact same flow it would have a different meaning.
On Fri, Jun 21, 2013 at 9:43 AM, A
Correction.
The ICMP mask will have to be fully masked in this example. But they still
need to be present in the netlink. A missing ICMP mask attribute will be
interpreted by the user space programs as exact match.
On Fri, Jun 21, 2013 at 9:38 AM, Andy Zhou wrote:
> Yes, you are right abou
Yes, you are right about the root cause.
A fully wildcarded ip proto in the key would prevent the mask of ICMP (may
not be fully wildcarded) to be generated.
This patch fixes it.
Andy
On Fri, Jun 21, 2013 at 9:27 AM, Jesse Gross wrote:
> On Thu, Jun 20, 2013 at 11:38 PM, Andy Zhou wrote:
>
On Thu, Jun 20, 2013 at 11:38 PM, Andy Zhou wrote:
> Fix a bug where some mask attributes are missing in the netlink packets
> from kernel to the user space.
>
> Reported-by: Justin Pettit
> Signed-off-by: Andy Zhou
Can you describe this some more? Presumably, this is because some of
the prereq
Fix a bug where some mask attributes are missing in the netlink packets
from kernel to the user space.
Reported-by: Justin Pettit
Signed-off-by: Andy Zhou
---
datapath/datapath.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
ind
