Re: [ovs-dev] [PATCH] bfd: Add bfd_src_ip and bfd_dst_ip.

2014-01-21 Thread Alex Wang
Changes are committed to master, thx.~ On Tue, Jan 21, 2014 at 11:25 AM, Alex Wang wrote: > Thanks Ethan, all make sense, I'll learn how to apply it myself. > > > > On Tue, Jan 21, 2014 at 11:01 AM, Ethan Jackson wrote: > >> > +bfd->ip_src = htonl(0xA9FE0100); /* 169.254.1.0. */ >> > +

Re: [ovs-dev] [PATCH] bfd: Add bfd_src_ip and bfd_dst_ip.

2014-01-21 Thread Alex Wang
Thanks Ethan, all make sense, I'll learn how to apply it myself. On Tue, Jan 21, 2014 at 11:01 AM, Ethan Jackson wrote: > > +bfd->ip_src = htonl(0xA9FE0100); /* 169.254.1.0. */ > > +bfd->ip_dst = htonl(0xA9FE0101); /* 169.254.1.1. */ > > + > > I don't see a reason to set the def

Re: [ovs-dev] [PATCH] bfd: Add bfd_src_ip and bfd_dst_ip.

2014-01-21 Thread Ethan Jackson
> +bfd->ip_src = htonl(0xA9FE0100); /* 169.254.1.0. */ > +bfd->ip_dst = htonl(0xA9FE0101); /* 169.254.1.1. */ > + I don't see a reason to set the defaults here as it will just get set again later if the IP address fails to parse. > + > + Set to an IPv4 address, e.g

[ovs-dev] [PATCH] bfd: Add bfd_src_ip and bfd_dst_ip.

2014-01-17 Thread Alex Wang
This commit adds two new options, bfd_src_ip and bfd_dst_ip respectively, which allows user to configure the source and destination IP address of bfd control packet. If the user specified address cannot be parsed, the default address will be used. Signed-off-by: Alex Wang --- lib/bfd.c