> +        bfd->ip_src = htonl(0xA9FE0100); /* 169.254.1.0. */
> +        bfd->ip_dst = htonl(0xA9FE0101); /* 169.254.1.1. */
> +

I don't see a reason to set the defaults here as it will just get set
again later if the IP address fails to parse.

> +       <column name="bfd" key="bfd_src_ip">
> +          Set to an IPv4 address, e.g. 192.168.0.123, to set the IP address
> +          used as source for transmitted BFD packets.  The default is
> +          <code>169.254.1.0</code>.
> +       </column>

If a user doesn't know what an IPv4 address is they shouldn't be using
the feature =).  I'd remove the example.

Acked-by: Ethan Jackson <et...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to