Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-22 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 05:39:22PM +0100, Damien Millescamps wrote: > On 03/22/2013 05:01 PM, Ben Pfaff wrote: > > This is about Automake, not Autoconf. > > Rules that update the source directory are appropriate to update files > > that are distributed. If you disagree, then feel free to report a

Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-22 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 04:46:52PM +0100, Damien Millescamps wrote: > On 03/21/2013 08:44 PM, Ben Pfaff wrote: > > On Thu, Mar 21, 2013 at 10:52:37AM +0100, Damien Millescamps wrote: > >> On 03/20/2013 10:20 PM, Ben Pfaff wrote: > > The straightforward solution is to use a writable source directory

Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-21 Thread Ben Pfaff
On Thu, Mar 21, 2013 at 10:52:37AM +0100, Damien Millescamps wrote: > On 03/20/2013 10:20 PM, Ben Pfaff wrote: > > Some more background: we don't require Python to build because very > > old versions of the XenServer DDK (under which we have to build OVS to > > produce XenServer binaries) did not i

Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-20 Thread Ben Pfaff
On Wed, Mar 20, 2013 at 09:19:06PM +0100, Damien Millescamps wrote: > On 03/20/2013 08:29 PM, Ben Pfaff wrote: > > On Tue, Mar 19, 2013 at 12:22:31PM -0700, Ben Pfaff wrote: > >> > From: Damien Millescamps > >> > > >> > This patch fixes a build error when OVS is built from a > >> > read-only repo

Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-20 Thread Ben Pfaff
On Tue, Mar 19, 2013 at 12:22:31PM -0700, Ben Pfaff wrote: > From: Damien Millescamps > > This patch fixes a build error when OVS is built from a > read-only repository. lib/ofp-errors.inc is a distributed file, so it has to be in the source directory rather than the build directory. If you use

[ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-19 Thread Ben Pfaff
From: Damien Millescamps This patch fixes a build error when OVS is built from a read-only repository. To reproduce this issue run: chmod -R a-w . mkdir ../build-ovs; cd ../build-ovs ../openvswitch/configure && make Signed-off-by: Damien Millescamps --- Reposting for Damien because of email is