Re: [ovs-dev] [PATCH] Use struct nicira_header nxh in struct nx_set_flow_format

2012-02-27 Thread Simon Horman
On Mon, Feb 27, 2012 at 06:37:19PM -0800, Ben Pfaff wrote: > On Tue, Feb 28, 2012 at 10:59:44AM +0900, Simon Horman wrote: > > On Mon, Feb 27, 2012 at 04:51:45PM -0800, Chris Wright wrote: > > > * Simon Horman (ho...@verge.net.au) wrote: > > > > This makes struct nx_set_flow_format consistent with

Re: [ovs-dev] [PATCH] Use struct nicira_header nxh in struct nx_set_flow_format

2012-02-27 Thread Ben Pfaff
On Tue, Feb 28, 2012 at 10:59:44AM +0900, Simon Horman wrote: > On Mon, Feb 27, 2012 at 04:51:45PM -0800, Chris Wright wrote: > > * Simon Horman (ho...@verge.net.au) wrote: > > > This makes struct nx_set_flow_format consistent with > > > other similar structures. > > > > > > Signed-off-by: Simon H

Re: [ovs-dev] [PATCH] Use struct nicira_header nxh in struct nx_set_flow_format

2012-02-27 Thread Simon Horman
On Mon, Feb 27, 2012 at 04:51:45PM -0800, Chris Wright wrote: > * Simon Horman (ho...@verge.net.au) wrote: > > This makes struct nx_set_flow_format consistent with > > other similar structures. > > > > Signed-off-by: Simon Horman > > Looks good to me. > > Acked-by: Chris Wright > > BTW, struc

Re: [ovs-dev] [PATCH] Use struct nicira_header nxh in struct nx_set_flow_format

2012-02-27 Thread Ben Pfaff
On Mon, Feb 27, 2012 at 04:51:45PM -0800, Chris Wright wrote: > * Simon Horman (ho...@verge.net.au) wrote: > > This makes struct nx_set_flow_format consistent with > > other similar structures. > > > > Signed-off-by: Simon Horman > > Looks good to me. > > Acked-by: Chris Wright > > BTW, struc

Re: [ovs-dev] [PATCH] Use struct nicira_header nxh in struct nx_set_flow_format

2012-02-27 Thread Chris Wright
* Simon Horman (ho...@verge.net.au) wrote: > This makes struct nx_set_flow_format consistent with > other similar structures. > > Signed-off-by: Simon Horman Looks good to me. Acked-by: Chris Wright BTW, struct nx_flow_mod_table_id vendor/subtype would default to arch-Endian, (which seems lik

[ovs-dev] [PATCH] Use struct nicira_header nxh in struct nx_set_flow_format

2012-02-27 Thread Simon Horman
This makes struct nx_set_flow_format consistent with other similar structures. Signed-off-by: Simon Horman --- include/openflow/nicira-ext.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h index 042d304..ae