On Mon, Feb 27, 2012 at 04:51:45PM -0800, Chris Wright wrote:
> * Simon Horman (ho...@verge.net.au) wrote:
> > This makes struct nx_set_flow_format consistent with
> > other similar structures.
> >
> > Signed-off-by: Simon Horman <ho...@verge.net.au>
>
> Looks good to me.
>
> Acked-by: Chris Wright <chr...@sous-sol.org>
>
> BTW, struct nx_flow_mod_table_id vendor/subtype would default to arch-Endian,
> (which seems like an oversight otherwise could get the same treatment).
Hi Chris,
I took a look over the code and that seems like an oversight to me.
----------------------------------------------------------------------
Use struct nicira_header nxh in nx_flow_mod_table_id
This makes struct nx_set_flow_format consistent with
other similar structures.
It also uses a type of the correct (network) byte order for
the vendor and subtype fields of tstruct nx_set_flow_format.
Reported-by: Chris Wright <chr...@sous-sol.org>
Signed-off-by: Simon Horman <ho...@verge.net.au>
---
Compile tested only
---
include/openflow/nicira-ext.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
index b66b806..db67bc8 100644
--- a/include/openflow/nicira-ext.h
+++ b/include/openflow/nicira-ext.h
@@ -192,9 +192,7 @@ enum nx_hash_fields {
* table match, then none is modified or deleted.
*/
struct nx_flow_mod_table_id {
- struct ofp_header header;
- uint32_t vendor; /* NX_VENDOR_ID. */
- uint32_t subtype; /* NXT_FLOW_MOD_TABLE_ID. */
+ struct nicira_header nxh;
uint8_t set; /* Nonzero to enable, zero to disable. */
uint8_t pad[7];
};
--
1.7.6.3
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
