Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for event subscription

2014-09-10 Thread Eitan Eliahu
Sure will do a) Thanks Eitan -Original Message- From: Nithin Raju Sent: Wednesday, September 10, 2014 12:45 PM To: Eitan Eliahu Cc: Subject: Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for event subscription On Sep 10, 2014, at 12:40 PM, Eitan Eliahu wrote

Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for event subscription

2014-09-10 Thread Nithin Raju
On Sep 10, 2014, at 12:40 PM, Eitan Eliahu wrote: > Nithin, I can't align it since if aligned this line will go over the 80 > character limit. You could do one of these two options. Either way is fine: a) +nl_msg_put_genlmsghdr(&request, 0, OVS_WIN_NL_CTRL_FAMILY_ID, 0, +

Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for event subscription

2014-09-10 Thread Eitan Eliahu
Nithin, I can't align it since if aligned this line will go over the 80 character limit. Thank you. Eitan -Original Message- From: Nithin Raju Sent: Wednesday, September 10, 2014 12:38 PM To: Eitan Eliahu Cc: Subject: Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC grou

Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for event subscription

2014-09-10 Thread Nithin Raju
Eitan, Thanks for doing this. I had some minor comments. LG otherwise. Acked-by: Nithin Raju > +OVS_NL_ATTR_MCAST_JOIN, /*1/0 - Join/Unjoin */ minor: need a space before '1/0'. > +nl_msg_put_genlmsghdr(&request, 0, OVS_WIN_NL_CTRL_FAMILY_ID, 0, > + OVS_CTRL_CMD_

[ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for event subscription

2014-09-10 Thread Eitan Eliahu
Use a specific out of band device control to subscribe/unsubscribe a socket to the driver event queue for notification. Signed-off-by: Eitan Eliahu --- datapath-windows/include/OvsDpInterfaceExt.h | 7 +++ lib/netlink-socket.c | 81 +--- 2 files c